From: Liu Yi L <yi.l.liu@intel.com>
To: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com,
alex.williamson@redhat.com, peterx@redhat.com
Cc: eric.auger@redhat.com, david@gibson.dropbear.id.au,
tianyu.lan@intel.com, kevin.tian@intel.com, yi.l.liu@intel.com,
jun.j.tian@intel.com, yi.y.sun@intel.com, kvm@vger.kernel.org,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Yi Sun <yi.y.sun@linux.intel.com>
Subject: [RFC v1 17/18] intel_iommu: propagate PASID-based iotlb flush to host
Date: Fri, 5 Jul 2019 19:01:50 +0800 [thread overview]
Message-ID: <1562324511-2910-18-git-send-email-yi.l.liu@intel.com> (raw)
In-Reply-To: <1562324511-2910-1-git-send-email-yi.l.liu@intel.com>
Intel VT-d 3.0 supports nested translation in PASID granularity. For guest
SVA support, nested translation is enabled for specific PASID. In such case,
guest owns the GVA->GPA translation which is configured as first level page
table in host side for a specific pasid, and host owns GPA->HPA translation.
As guest owns first level translation table, guest's PASID-based IOTLB(piotlb)
flush should be propagated to host since host IOMMU will cache first level
page table related mappings during DMA address translation.
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Yi Sun <yi.y.sun@linux.intel.com>
Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
---
hw/i386/intel_iommu.c | 68 ++++++++++++++++++++++++++++++++++++++++++
hw/i386/intel_iommu_internal.h | 7 +++++
2 files changed, 75 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 7a778d8..e4286e5 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2516,15 +2516,83 @@ static bool vtd_process_pasid_desc(IntelIOMMUState *s,
return (ret == 0) ? true : false;
}
+static inline bool vtd_pasid_cache_valid(VTDAddressSpace *vtd_pasid_as)
+{
+ return (vtd_pasid_as->iommu_state->pasid_cache_gen &&
+ (vtd_pasid_as->iommu_state->pasid_cache_gen
+ == vtd_pasid_as->pasid_cache_entry.pasid_cache_gen));
+}
+
+static void vtd_flush_pasid_iotlb(gpointer key, gpointer value,
+ gpointer user_data)
+{
+ VTDPIOTLBInvInfo *piotlb_info = user_data;
+ VTDAddressSpace *vtd_pasid_as = value;
+ uint16_t did;
+
+ /*
+ * Actually, needs to check whether the pasid entry cache stored in
+ * vtd_pasid_as is valid or not. "invalid" means the pasid cache
+ * has been flushed, thus host should have done such piotlb flush,
+ * no need to pass down piotlb flush to host. Only when pasid entry
+ * cache is "valid", should a piotlb flush pass down to host. Because
+ * In such case, it is due to mapping changes in guest, a piotlb flush
+ * in host is required.
+ */
+ if (!vtd_pasid_as || !vtd_pasid_cache_valid(vtd_pasid_as)) {
+ return;
+ }
+
+ did = vtd_pe_get_domain_id(
+ &(vtd_pasid_as->pasid_cache_entry.pasid_entry));
+ /*
+ * vtd_pasid_as should be non-NULL and the pasid_cache_gen
+ * should be non-zero. If vtd_pasid_as management is clean,
+ * the vtd_pasid_as is non-NULL is enough.
+ */
+ if ((piotlb_info->domain_id == did) &&
+ (piotlb_info->pasid == vtd_pasid_as->pasid)) {
+ pci_device_flush_pasid_iotlb(vtd_pasid_as->bus,
+ vtd_pasid_as->devfn, &piotlb_info->tlb_info);
+ }
+}
+
static void vtd_piotlb_pasid_invalidate(IntelIOMMUState *s,
uint16_t domain_id,
uint32_t pasid)
{
+ VTDPIOTLBInvInfo piotlb_info;
+ struct iommu_cache_invalidate_info *inv_info = &piotlb_info.tlb_info;
+
+ piotlb_info.domain_id = domain_id;
+ piotlb_info.pasid = pasid;
+ inv_info->version = IOMMU_CACHE_INVALIDATE_INFO_VERSION_1;
+ inv_info->cache = IOMMU_CACHE_INV_TYPE_IOTLB;
+ inv_info->granularity = IOMMU_INV_GRANU_PASID;
+ inv_info->pasid_info.pasid = pasid;
+ inv_info->pasid_info.flags = IOMMU_INV_PASID_FLAGS_PASID;
+ g_hash_table_foreach(s->vtd_pasid_as, vtd_flush_pasid_iotlb, &piotlb_info);
}
static void vtd_piotlb_page_invalidate(IntelIOMMUState *s, uint16_t domain_id,
uint32_t pasid, hwaddr addr, uint8_t am, bool ih)
{
+ VTDPIOTLBInvInfo piotlb_info;
+ struct iommu_cache_invalidate_info *inv_info = &piotlb_info.tlb_info;
+
+ piotlb_info.domain_id = domain_id;
+ piotlb_info.pasid = pasid;
+ inv_info->version = IOMMU_CACHE_INVALIDATE_INFO_VERSION_1;
+ inv_info->cache = IOMMU_CACHE_INV_TYPE_IOTLB;
+ inv_info->granularity = IOMMU_INV_GRANU_ADDR;
+ inv_info->addr_info.flags = IOMMU_INV_ADDR_FLAGS_PASID;
+ inv_info->addr_info.flags |= ih ? IOMMU_INV_ADDR_FLAGS_LEAF : 0;
+ inv_info->addr_info.pasid = pasid;
+ inv_info->addr_info.addr = addr;
+ inv_info->addr_info.granule_size = 1 << (12 + am);
+ inv_info->addr_info.nb_granules = 1;
+
+ g_hash_table_foreach(s->vtd_pasid_as, vtd_flush_pasid_iotlb, &piotlb_info);
}
static bool vtd_process_piotlb_desc(IntelIOMMUState *s,
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
index 69cd879..556ea8d 100644
--- a/hw/i386/intel_iommu_internal.h
+++ b/hw/i386/intel_iommu_internal.h
@@ -506,6 +506,13 @@ struct VTDPASIDCacheInfo {
};
typedef struct VTDPASIDCacheInfo VTDPASIDCacheInfo;
+struct VTDPIOTLBInvInfo {
+ uint16_t domain_id;
+ uint32_t pasid;
+ struct iommu_cache_invalidate_info tlb_info;
+};
+typedef struct VTDPIOTLBInvInfo VTDPIOTLBInvInfo;
+
/* Masks for struct VTDRootEntry */
#define VTD_ROOT_ENTRY_P 1ULL
#define VTD_ROOT_ENTRY_CTP (~0xfffULL)
--
2.7.4
next prev parent reply other threads:[~2019-07-06 11:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 11:01 [RFC v1 00/18] intel_iommu: expose Shared Virtual Addressing to VM Liu Yi L
2019-07-05 11:01 ` [RFC v1 01/18] linux-headers: import iommu.h from kernel Liu Yi L
2019-07-05 11:01 ` [RFC v1 02/18] linux-headers: import vfio.h " Liu Yi L
2019-07-09 1:58 ` Peter Xu
2019-07-09 8:37 ` Auger Eric
2019-07-10 12:31 ` Liu, Yi L
2019-07-10 12:29 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 03/18] hw/pci: introduce PCIPASIDOps to PCIDevice Liu Yi L
2019-07-09 2:12 ` Peter Xu
2019-07-09 10:41 ` Auger Eric
2019-07-10 11:08 ` Liu, Yi L
2019-07-11 3:51 ` david
2019-07-11 7:13 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 04/18] intel_iommu: add "sm_model" option Liu Yi L
2019-07-09 2:15 ` Peter Xu
2019-07-10 12:14 ` Liu, Yi L
2019-07-11 1:03 ` Peter Xu
2019-07-11 6:25 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 05/18] vfio/pci: add pasid alloc/free implementation Liu Yi L
2019-07-09 2:23 ` Peter Xu
2019-07-10 12:16 ` Liu, Yi L
2019-07-15 2:55 ` David Gibson
2019-07-16 10:25 ` Liu, Yi L
2019-07-17 3:06 ` David Gibson
2019-07-22 7:02 ` Liu, Yi L
2019-07-23 3:57 ` David Gibson
2019-07-24 4:57 ` Liu, Yi L
2019-07-24 9:33 ` Auger Eric
2019-07-25 3:40 ` David Gibson
2019-07-26 5:18 ` Liu, Yi L
2019-08-02 7:36 ` Auger Eric
2019-07-05 11:01 ` [RFC v1 06/18] intel_iommu: support virtual command emulation and pasid request Liu Yi L
2019-07-09 3:19 ` Peter Xu
2019-07-10 11:51 ` Liu, Yi L
2019-07-11 1:13 ` Peter Xu
2019-07-11 6:59 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 07/18] hw/pci: add pci_device_bind/unbind_gpasid Liu Yi L
2019-07-09 8:37 ` Auger Eric
2019-07-10 12:18 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 08/18] vfio/pci: add vfio bind/unbind_gpasid implementation Liu Yi L
2019-07-09 8:37 ` Auger Eric
2019-07-10 12:30 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 09/18] intel_iommu: process pasid cache invalidation Liu Yi L
2019-07-09 4:47 ` Peter Xu
2019-07-11 6:22 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 10/18] intel_iommu: tag VTDAddressSpace instance with PASID Liu Yi L
2019-07-09 6:12 ` Peter Xu
2019-07-11 7:24 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 11/18] intel_iommu: create VTDAddressSpace per BDF+PASID Liu Yi L
2019-07-09 6:39 ` Peter Xu
2019-07-11 8:13 ` Liu, Yi L
2019-07-05 11:01 ` [RFC v1 12/18] intel_iommu: bind/unbind guest page table to host Liu Yi L
2019-07-05 11:01 ` [RFC v1 13/18] intel_iommu: flush pasid cache after a DSI context cache flush Liu Yi L
2019-07-05 11:01 ` [RFC v1 14/18] hw/pci: add flush_pasid_iotlb() in PCIPASIDOps Liu Yi L
2019-07-05 11:01 ` [RFC v1 15/18] vfio/pci: adds support for PASID-based iotlb flush Liu Yi L
2019-07-05 11:01 ` [RFC v1 16/18] intel_iommu: add PASID-based iotlb invalidation support Liu Yi L
2019-07-05 11:01 ` Liu Yi L [this message]
2019-07-05 11:01 ` [RFC v1 18/18] intel_iommu: do not passdown pasid bind for PASID #0 Liu Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562324511-2910-18-git-send-email-yi.l.liu@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eric.auger@redhat.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jun.j.tian@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
--cc=yi.y.sun@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).