From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com, david@redhat.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com
Subject: [kvm-unit-tests PATCH v4 0/3] s390x: SCLP Unit test
Date: Tue, 19 Nov 2019 10:53:36 +0100 [thread overview]
Message-ID: <1574157219-22052-1-git-send-email-imbrenda@linux.ibm.com> (raw)
This patchset contains some minor cleanup, some preparatory work and
then the SCLP unit test itself.
The unit test checks the following:
* Correctly ignoring instruction bits that should be ignored
* Privileged instruction check
* Check for addressing exceptions
* Specification exceptions:
- SCCB size less than 8
- SCCB unaligned
- SCCB overlaps prefix or lowcore
- SCCB address higher than 2GB
* Return codes for
- Invalid command
- SCCB too short (but at least 8)
- SCCB page boundary violation
v3 -> v4
* export sclp_setup_int instead of copying it
* add more comments
* rename some more variables to improve readability
* improve the prefix test
* improved the invalid address test
* addressed further comments received during review
v2 -> v3
* generally improved the naming of variables
* added and fixed comments
* renamed test_one_run to test_one_simple
* added some const where needed
* addresed many more small comments received during review
v1 -> v2
* fix many small issues that came up during the first round of reviews
* add comments to each function
* use a static buffer for the SCCP template when used
Claudio Imbrenda (3):
s390x: export sclp_setup_int
s390x: sclp: add service call instruction wrapper
s390x: SCLP unit test
s390x/Makefile | 1 +
lib/s390x/asm/arch_def.h | 13 ++
lib/s390x/sclp.h | 1 +
lib/s390x/sclp.c | 9 +-
s390x/sclp.c | 465 +++++++++++++++++++++++++++++++++++++++++++++++
s390x/unittests.cfg | 3 +
6 files changed, 485 insertions(+), 7 deletions(-)
create mode 100644 s390x/sclp.c
--
2.7.4
next reply other threads:[~2019-11-19 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 9:53 Claudio Imbrenda [this message]
2019-11-19 9:53 ` [kvm-unit-tests PATCH v4 1/3] s390x: export sclp_setup_int Claudio Imbrenda
2019-11-19 13:14 ` Thomas Huth
2019-11-27 18:00 ` Janosch Frank
2019-11-27 18:01 ` Janosch Frank
2019-11-19 9:53 ` [kvm-unit-tests PATCH v4 2/3] s390x: sclp: add service call instruction wrapper Claudio Imbrenda
2019-11-19 9:53 ` [kvm-unit-tests PATCH v4 3/3] s390x: SCLP unit test Claudio Imbrenda
2019-11-20 18:16 ` Thomas Huth
2019-11-27 18:21 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574157219-22052-1-git-send-email-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).