From: Halil Pasic <pasic@linux.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Petr Tesarik <ptesarik@suse.cz>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>
Subject: Re: [PATCH 1/1] s390/dma: provide proper ARCH_ZONE_DMA_BITS value
Date: Tue, 23 Jul 2019 14:32:26 +0200 [thread overview]
Message-ID: <20190723143226.6d929d7a.pasic@linux.ibm.com> (raw)
In-Reply-To: <20190719130130.3ef4fa9c.pasic@linux.ibm.com>
On Fri, 19 Jul 2019 13:01:30 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:
> > > diff --git a/arch/s390/include/asm/dma.h b/arch/s390/include/asm/dma.h
> > > index 6f26f35d4a71..3b0329665b13 100644
> > > --- a/arch/s390/include/asm/dma.h
> > > +++ b/arch/s390/include/asm/dma.h
> > > @@ -10,6 +10,7 @@
> > > * by the 31 bit heritage.
> > > */
> > > #define MAX_DMA_ADDRESS 0x80000000
> > > +#define ARCH_ZONE_DMA_BITS 31
> >
> > powerpc has this in arch/powerpc/include/asm/page.h. This really
> > should be consistently defined in the same header file across
> > architectures.
> >
> > Christoph, what is the preferred header file for this definition?
ping
Christoph could you please answer Heiko's question, so I can do my
respin.
Regards,
Halil
> >
> > I'd also rather say it would be better to move the #ifndef ARCH_ZONE_DMA_BITS
> > check to a common code header file instead of having it in a C file, and
> > make it more obvious in which header file architectures should/can override
> > the default, no?
>
> +1
>
> I will wait for Christoph's answer with a respin. Thanks for having a
> look.
next prev parent reply other threads:[~2019-07-23 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 17:21 [PATCH 1/1] s390/dma: provide proper ARCH_ZONE_DMA_BITS value Halil Pasic
2019-07-18 20:54 ` Petr Tesarik
2019-07-19 6:32 ` Heiko Carstens
2019-07-19 11:01 ` Halil Pasic
2019-07-23 12:32 ` Halil Pasic [this message]
2019-07-23 15:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723143226.6d929d7a.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).