kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com,
	maz@kernel.org, andre.przywara@arm.com, vladimir.murzin@arm.com,
	mark.rutland@arm.com
Subject: Re: [kvm-unit-tests PATCH v2 00/18] arm/arm64: Various fixes
Date: Fri, 13 Dec 2019 19:51:41 +0100	[thread overview]
Message-ID: <20191213185141.swqwi3jbkheakk3f@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20191128180418.6938-1-alexandru.elisei@arm.com>

On Thu, Nov 28, 2019 at 06:04:00PM +0000, Alexandru Elisei wrote:
> This is a combination of the fixes from my EL2 series [1] and other new
> fixes.
> 
> Changes in v2:
> * Fixed the prefetch abort test on QEMU by changing the address used to
>   cause the abort.
> 
> Summary of the patches:
> * Patch 1 adds coherent translation table walks for ARMv7 and removes
>   unneeded dcache maintenance.
> * Patches 2-4 make translation table updates more robust.
> * Patches 5-6 fix a pretty serious bug in our PSCI test, which was causing
>   an infinite loop of prefetch aborts.
> * Patches 7-10 add a proper test for prefetch aborts. The test now uses
>   mmu_clear_user.
> * Patches 11-13 are fixes for the timer test.
> * Patches 14-15 fix turning the MMU off.
> * Patches 16-18 are small fixes to make the code more robust, and perhaps
>   more important, remove unnecessary operations that might hide real bugs
>   in KVM.
> 
> Patches 1-4, 9, 18 are new. The rest are taken from the EL2 series, and
> I've kept the Reviewed-by tag where appropriate. There are no major
> changes, only those caused by rebasing on top of the current kvm-unit-tests
> version.

This series looks good to me, but it needs another rebase due to 
a299895b7abb ("Switch the order of the parameters in report() and
report_xfail()") and there are a few minor comments to address.

> 
> Please review.
> 
> [1] https://www.spinics.net/lists/kvm/msg196797.html

It's almost at the top of the TODO! I might even get to it during the
holidays. Of course it could probably use a rebase now too.

Thanks,
drew


      parent reply	other threads:[~2019-12-13 20:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 18:04 [kvm-unit-tests PATCH v2 00/18] arm/arm64: Various fixes Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 01/18] lib: arm/arm64: Remove unnecessary dcache maintenance operations Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 02/18] lib: arm64: Remove barriers before TLB operations Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 03/18] lib: Add WRITE_ONCE and READ_ONCE implementations in compiler.h Alexandru Elisei
2019-12-09 14:21   ` Thomas Huth
2019-12-16 10:15     ` Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 04/18] lib: arm/arm64: Use WRITE_ONCE to update the translation tables Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 05/18] lib: arm/arm64: Remove unused CPU_OFF parameter Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 06/18] arm/arm64: psci: Don't run C code without stack or vectors Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 07/18] lib: arm/arm64: Add missing include for alloc_page.h in pgtable.h Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 08/18] lib: arm: Implement flush_tlb_all Alexandru Elisei
2019-11-28 23:24   ` André Przywara
2019-12-30  8:50     ` Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 09/18] lib: arm/arm64: Teach mmu_clear_user about block mappings Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 10/18] arm/arm64: selftest: Add prefetch abort test Alexandru Elisei
2019-12-13 18:04   ` Andrew Jones
2019-12-30  9:19     ` Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 11/18] arm64: timer: Write to ICENABLER to disable timer IRQ Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 12/18] arm64: timer: EOIR the interrupt after masking the timer Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 13/18] arm64: timer: Test behavior when timer disabled or masked Alexandru Elisei
2019-12-13 18:28   ` Andrew Jones
2019-12-30  9:21     ` Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 14/18] lib: arm/arm64: Refuse to disable the MMU with non-identity stack pointer Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 15/18] arm/arm64: Perform dcache clean + invalidate after turning MMU off Alexandru Elisei
2019-12-13 18:42   ` Andrew Jones
2019-12-30  9:29     ` Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 16/18] arm: cstart64.S: Downgrade TLBI to non-shareable in asm_mmu_enable Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 17/18] arm/arm64: Invalidate TLB before enabling MMU Alexandru Elisei
2019-11-28 18:04 ` [kvm-unit-tests PATCH v2 18/18] arm: cstart64.S: Remove icache invalidation from asm_mmu_enable Alexandru Elisei
2019-12-13 18:51 ` Andrew Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213185141.swqwi3jbkheakk3f@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=alexandru.elisei@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=vladimir.murzin@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).