From: Alex Williamson <alex.williamson@redhat.com>
To: Liu Yi L <yi.l.liu@intel.com>
Cc: kwankhede@nvidia.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kevin.tian@intel.com, joro@8bytes.org,
peterx@redhat.com, baolu.lu@linux.intel.com
Subject: Re: [PATCH v4 09/12] vfio: split vfio_pci_private.h into two files
Date: Thu, 9 Jan 2020 15:48:37 -0700 [thread overview]
Message-ID: <20200109154837.278274f7@w520.home> (raw)
In-Reply-To: <1578398509-26453-10-git-send-email-yi.l.liu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 10691 bytes --]
On Tue, 7 Jan 2020 20:01:46 +0800
Liu Yi L <yi.l.liu@intel.com> wrote:
> This patch splits the vfio_pci_private.h to be a private file
> in drivers/vfio/pci and a common file under include/linux/. It
> is a preparation for supporting vfio_pci common code sharing
> outside drivers/vfio/pci/.
>
> The common header file is shrunk from the previous copied
> vfio_pci_common.h. The original vfio_pci_private.h is shrunk
> accordingly as well.
>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
> ---
> drivers/vfio/pci/vfio_pci_private.h | 133 +-----------------------------------
> include/linux/vfio_pci_common.h | 86 ++---------------------
> 2 files changed, 7 insertions(+), 212 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
> index 499dd04..c4976a9 100644
> --- a/drivers/vfio/pci/vfio_pci_private.h
> +++ b/drivers/vfio/pci/vfio_pci_private.h
> @@ -12,6 +12,7 @@
> #include <linux/pci.h>
> #include <linux/irqbypass.h>
> #include <linux/types.h>
> +#include <linux/vfio_pci_common.h>
>
> #ifndef VFIO_PCI_PRIVATE_H
> #define VFIO_PCI_PRIVATE_H
> @@ -39,121 +40,12 @@ struct vfio_pci_ioeventfd {
> int count;
> };
>
> -struct vfio_pci_irq_ctx {
> - struct eventfd_ctx *trigger;
> - struct virqfd *unmask;
> - struct virqfd *mask;
> - char *name;
> - bool masked;
> - struct irq_bypass_producer producer;
> -};
I think this can stay here, vfio_pci_common.h just needs a forward
declaration.
> -
> -struct vfio_pci_device;
> -struct vfio_pci_region;
> -
> -struct vfio_pci_regops {
> - size_t (*rw)(struct vfio_pci_device *vdev, char __user *buf,
> - size_t count, loff_t *ppos, bool iswrite);
> - void (*release)(struct vfio_pci_device *vdev,
> - struct vfio_pci_region *region);
> - int (*mmap)(struct vfio_pci_device *vdev,
> - struct vfio_pci_region *region,
> - struct vm_area_struct *vma);
> - int (*add_capability)(struct vfio_pci_device *vdev,
> - struct vfio_pci_region *region,
> - struct vfio_info_cap *caps);
> -};
> -
> -struct vfio_pci_region {
> - u32 type;
> - u32 subtype;
> - const struct vfio_pci_regops *ops;
> - void *data;
> - size_t size;
> - u32 flags;
> -};
> -
> struct vfio_pci_dummy_resource {
> struct resource resource;
> int index;
> struct list_head res_next;
> };
>
> -struct vfio_pci_reflck {
> - struct kref kref;
> - struct mutex lock;
> -};
I think we can abstract this a little further to make it unnecessary to
put this in common as well. See attached.
> -
> -struct vfio_pci_device {
> - struct pci_dev *pdev;
> - void __iomem *barmap[PCI_STD_NUM_BARS];
> - bool bar_mmap_supported[PCI_STD_NUM_BARS];
> - u8 *pci_config_map;
> - u8 *vconfig;
> - struct perm_bits *msi_perm;
> - spinlock_t irqlock;
> - struct mutex igate;
> - struct vfio_pci_irq_ctx *ctx;
> - int num_ctx;
> - int irq_type;
> - int num_regions;
> - struct vfio_pci_region *region;
> - u8 msi_qmax;
> - u8 msix_bar;
> - u16 msix_size;
> - u32 msix_offset;
> - u32 rbar[7];
> - bool pci_2_3;
> - bool virq_disabled;
> - bool reset_works;
> - bool extended_caps;
> - bool bardirty;
> - bool has_vga;
> - bool needs_reset;
> - bool nointx;
> - bool needs_pm_restore;
> - struct pci_saved_state *pci_saved_state;
> - struct pci_saved_state *pm_save;
> - struct vfio_pci_reflck *reflck;
> - int refcnt;
> - int ioeventfds_nr;
> - struct eventfd_ctx *err_trigger;
> - struct eventfd_ctx *req_trigger;
> - struct list_head dummy_resources_list;
> - struct mutex ioeventfds_lock;
> - struct list_head ioeventfds_list;
> - bool nointxmask;
> -#ifdef CONFIG_VFIO_PCI_VGA
> - bool disable_vga;
> -#endif
> - bool disable_idle_d3;
> -};
> -
> -#define is_intx(vdev) (vdev->irq_type == VFIO_PCI_INTX_IRQ_INDEX)
> -#define is_msi(vdev) (vdev->irq_type == VFIO_PCI_MSI_IRQ_INDEX)
> -#define is_msix(vdev) (vdev->irq_type == VFIO_PCI_MSIX_IRQ_INDEX)
> -#define is_irq_none(vdev) (!(is_intx(vdev) || is_msi(vdev) || is_msix(vdev)))
> -#define irq_is(vdev, type) (vdev->irq_type == type)
I think these can stay in the private header too.
> -
> -extern const struct pci_error_handlers vfio_err_handlers;
> -
> -static inline bool vfio_pci_is_vga(struct pci_dev *pdev)
> -{
> - return (pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA;
> -}
> -
> -static inline bool vfio_vga_disabled(struct vfio_pci_device *vdev)
> -{
> -#ifdef CONFIG_VFIO_PCI_VGA
> - return vdev->disable_vga;
> -#else
> - return true;
> -#endif
> -}
vfio_vga_disabled() is only used in vfio_pci_common.c, I think it can
remain in private.
> -
> -extern void vfio_pci_refresh_config(struct vfio_pci_device *vdev,
> - bool nointxmask, bool disable_idle_d3);
> -
> extern void vfio_pci_intx_mask(struct vfio_pci_device *vdev);
> extern void vfio_pci_intx_unmask(struct vfio_pci_device *vdev);
>
> @@ -180,29 +72,6 @@ extern void vfio_pci_uninit_perm_bits(void);
> extern int vfio_config_init(struct vfio_pci_device *vdev);
> extern void vfio_config_free(struct vfio_pci_device *vdev);
>
> -extern int vfio_pci_register_dev_region(struct vfio_pci_device *vdev,
> - unsigned int type, unsigned int subtype,
> - const struct vfio_pci_regops *ops,
> - size_t size, u32 flags, void *data);
> -
> -extern int vfio_pci_set_power_state(struct vfio_pci_device *vdev,
> - pci_power_t state);
> -extern unsigned int vfio_pci_set_vga_decode(void *opaque, bool single_vga);
> -extern int vfio_pci_enable(struct vfio_pci_device *vdev);
> -extern void vfio_pci_disable(struct vfio_pci_device *vdev);
> -extern long vfio_pci_ioctl(void *device_data,
> - unsigned int cmd, unsigned long arg);
> -extern ssize_t vfio_pci_read(void *device_data, char __user *buf,
> - size_t count, loff_t *ppos);
> -extern ssize_t vfio_pci_write(void *device_data, const char __user *buf,
> - size_t count, loff_t *ppos);
> -extern int vfio_pci_mmap(void *device_data, struct vm_area_struct *vma);
> -extern void vfio_pci_request(void *device_data, unsigned int count);
> -extern void vfio_pci_fill_ids(char *ids, struct pci_driver *driver);
> -extern int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
> -extern void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck);
> -extern void vfio_pci_probe_power_state(struct vfio_pci_device *vdev);
> -
> #ifdef CONFIG_VFIO_PCI_IGD
> extern int vfio_pci_igd_init(struct vfio_pci_device *vdev);
> #else
> diff --git a/include/linux/vfio_pci_common.h b/include/linux/vfio_pci_common.h
> index 499dd04..862cd80 100644
> --- a/include/linux/vfio_pci_common.h
> +++ b/include/linux/vfio_pci_common.h
> @@ -1,5 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> + * VFIO PCI API definition
> + *
> + * Derived from original vfio/pci/vfio_pci_private.h:
> * Copyright (C) 2012 Red Hat, Inc. All rights reserved.
> * Author: Alex Williamson <alex.williamson@redhat.com>
> *
> @@ -13,31 +16,8 @@
> #include <linux/irqbypass.h>
> #include <linux/types.h>
>
> -#ifndef VFIO_PCI_PRIVATE_H
> -#define VFIO_PCI_PRIVATE_H
> -
> -#define VFIO_PCI_OFFSET_SHIFT 40
> -
> -#define VFIO_PCI_OFFSET_TO_INDEX(off) (off >> VFIO_PCI_OFFSET_SHIFT)
> -#define VFIO_PCI_INDEX_TO_OFFSET(index) ((u64)(index) << VFIO_PCI_OFFSET_SHIFT)
> -#define VFIO_PCI_OFFSET_MASK (((u64)(1) << VFIO_PCI_OFFSET_SHIFT) - 1)
> -
> -/* Special capability IDs predefined access */
> -#define PCI_CAP_ID_INVALID 0xFF /* default raw access */
> -#define PCI_CAP_ID_INVALID_VIRT 0xFE /* default virt access */
> -
> -/* Cap maximum number of ioeventfds per device (arbitrary) */
> -#define VFIO_PCI_IOEVENTFD_MAX 1000
> -
> -struct vfio_pci_ioeventfd {
> - struct list_head next;
> - struct virqfd *virqfd;
> - void __iomem *addr;
> - uint64_t data;
> - loff_t pos;
> - int bar;
> - int count;
> -};
> +#ifndef VFIO_PCI_COMMON_H
> +#define VFIO_PCI_COMMON_H
>
> struct vfio_pci_irq_ctx {
> struct eventfd_ctx *trigger;
> @@ -73,12 +53,6 @@ struct vfio_pci_region {
> u32 flags;
> };
>
> -struct vfio_pci_dummy_resource {
> - struct resource resource;
> - int index;
> - struct list_head res_next;
> -};
> -
> struct vfio_pci_reflck {
> struct kref kref;
> struct mutex lock;
> @@ -154,32 +128,6 @@ static inline bool vfio_vga_disabled(struct vfio_pci_device *vdev)
> extern void vfio_pci_refresh_config(struct vfio_pci_device *vdev,
> bool nointxmask, bool disable_idle_d3);
>
> -extern void vfio_pci_intx_mask(struct vfio_pci_device *vdev);
> -extern void vfio_pci_intx_unmask(struct vfio_pci_device *vdev);
> -
> -extern int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev,
> - uint32_t flags, unsigned index,
> - unsigned start, unsigned count, void *data);
> -
> -extern ssize_t vfio_pci_config_rw(struct vfio_pci_device *vdev,
> - char __user *buf, size_t count,
> - loff_t *ppos, bool iswrite);
> -
> -extern ssize_t vfio_pci_bar_rw(struct vfio_pci_device *vdev, char __user *buf,
> - size_t count, loff_t *ppos, bool iswrite);
> -
> -extern ssize_t vfio_pci_vga_rw(struct vfio_pci_device *vdev, char __user *buf,
> - size_t count, loff_t *ppos, bool iswrite);
> -
> -extern long vfio_pci_ioeventfd(struct vfio_pci_device *vdev, loff_t offset,
> - uint64_t data, int count, int fd);
> -
> -extern int vfio_pci_init_perm_bits(void);
> -extern void vfio_pci_uninit_perm_bits(void);
> -
> -extern int vfio_config_init(struct vfio_pci_device *vdev);
> -extern void vfio_config_free(struct vfio_pci_device *vdev);
> -
> extern int vfio_pci_register_dev_region(struct vfio_pci_device *vdev,
> unsigned int type, unsigned int subtype,
> const struct vfio_pci_regops *ops,
> @@ -203,26 +151,4 @@ extern int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
> extern void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck);
> extern void vfio_pci_probe_power_state(struct vfio_pci_device *vdev);
>
> -#ifdef CONFIG_VFIO_PCI_IGD
> -extern int vfio_pci_igd_init(struct vfio_pci_device *vdev);
> -#else
> -static inline int vfio_pci_igd_init(struct vfio_pci_device *vdev)
> -{
> - return -ENODEV;
> -}
> -#endif
> -#ifdef CONFIG_VFIO_PCI_NVLINK2
> -extern int vfio_pci_nvdia_v100_nvlink2_init(struct vfio_pci_device *vdev);
> -extern int vfio_pci_ibm_npu2_init(struct vfio_pci_device *vdev);
> -#else
> -static inline int vfio_pci_nvdia_v100_nvlink2_init(struct vfio_pci_device *vdev)
> -{
> - return -ENODEV;
> -}
> -
> -static inline int vfio_pci_ibm_npu2_init(struct vfio_pci_device *vdev)
> -{
> - return -ENODEV;
> -}
> -#endif
> -#endif /* VFIO_PCI_PRIVATE_H */
> +#endif /* VFIO_PCI_COMMON_H */
[-- Attachment #2: return-to-private --]
[-- Type: application/octet-stream, Size: 3419 bytes --]
These don't seem to be necessary in common header
From: Alex Williamson <alex.williamson@redhat.com>
---
drivers/vfio/pci/vfio_pci_private.h | 29 +++++++++++++++++++++++++++++
include/linux/vfio_pci_common.h | 31 ++-----------------------------
2 files changed, 31 insertions(+), 29 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
index c4976a948aaa..bf1995cf417d 100644
--- a/drivers/vfio/pci/vfio_pci_private.h
+++ b/drivers/vfio/pci/vfio_pci_private.h
@@ -40,12 +40,41 @@ struct vfio_pci_ioeventfd {
int count;
};
+struct vfio_pci_irq_ctx {
+ struct eventfd_ctx *trigger;
+ struct virqfd *unmask;
+ struct virqfd *mask;
+ char *name;
+ bool masked;
+ struct irq_bypass_producer producer;
+};
+
struct vfio_pci_dummy_resource {
struct resource resource;
int index;
struct list_head res_next;
};
+struct vfio_pci_reflck {
+ struct kref kref;
+ struct mutex lock;
+};
+
+#define is_intx(vdev) (vdev->irq_type == VFIO_PCI_INTX_IRQ_INDEX)
+#define is_msi(vdev) (vdev->irq_type == VFIO_PCI_MSI_IRQ_INDEX)
+#define is_msix(vdev) (vdev->irq_type == VFIO_PCI_MSIX_IRQ_INDEX)
+#define is_irq_none(vdev) (!(is_intx(vdev) || is_msi(vdev) || is_msix(vdev)))
+#define irq_is(vdev, type) (vdev->irq_type == type)
+
+static inline bool vfio_vga_disabled(struct vfio_pci_device *vdev)
+{
+#ifdef CONFIG_VFIO_PCI_VGA
+ return vdev->disable_vga;
+#else
+ return true;
+#endif
+}
+
extern void vfio_pci_intx_mask(struct vfio_pci_device *vdev);
extern void vfio_pci_intx_unmask(struct vfio_pci_device *vdev);
diff --git a/include/linux/vfio_pci_common.h b/include/linux/vfio_pci_common.h
index 439666a8ce7a..fa572d388111 100644
--- a/include/linux/vfio_pci_common.h
+++ b/include/linux/vfio_pci_common.h
@@ -19,17 +19,10 @@
#ifndef VFIO_PCI_COMMON_H
#define VFIO_PCI_COMMON_H
-struct vfio_pci_irq_ctx {
- struct eventfd_ctx *trigger;
- struct virqfd *unmask;
- struct virqfd *mask;
- char *name;
- bool masked;
- struct irq_bypass_producer producer;
-};
-
+struct vfio_pci_irq_ctx;
struct vfio_pci_device;
struct vfio_pci_region;
+struct vfio_pci_reflck;
struct vfio_pci_regops {
size_t (*rw)(struct vfio_pci_device *vdev, char __user *buf,
@@ -53,11 +46,6 @@ struct vfio_pci_region {
u32 flags;
};
-struct vfio_pci_reflck {
- struct kref kref;
- struct mutex lock;
-};
-
struct vfio_pci_device {
struct pci_dev *pdev;
void __iomem *barmap[PCI_STD_NUM_BARS];
@@ -103,12 +91,6 @@ struct vfio_pci_device {
bool disable_idle_d3;
};
-#define is_intx(vdev) (vdev->irq_type == VFIO_PCI_INTX_IRQ_INDEX)
-#define is_msi(vdev) (vdev->irq_type == VFIO_PCI_MSI_IRQ_INDEX)
-#define is_msix(vdev) (vdev->irq_type == VFIO_PCI_MSIX_IRQ_INDEX)
-#define is_irq_none(vdev) (!(is_intx(vdev) || is_msi(vdev) || is_msix(vdev)))
-#define irq_is(vdev, type) (vdev->irq_type == type)
-
extern const struct pci_error_handlers vfio_pci_err_handlers;
static inline bool vfio_pci_is_vga(struct pci_dev *pdev)
@@ -116,15 +98,6 @@ static inline bool vfio_pci_is_vga(struct pci_dev *pdev)
return (pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA;
}
-static inline bool vfio_vga_disabled(struct vfio_pci_device *vdev)
-{
-#ifdef CONFIG_VFIO_PCI_VGA
- return vdev->disable_vga;
-#else
- return true;
-#endif
-}
-
extern void vfio_pci_refresh_config(struct vfio_pci_device *vdev,
bool nointxmask, bool disable_idle_d3);
[-- Attachment #3: abstract-reflck --]
[-- Type: application/octet-stream, Size: 5195 bytes --]
Make it (more) abstract
From: Alex Williamson <alex.williamson@redhat.com>
---
drivers/vfio/pci/vfio_pci.c | 10 +++++-----
drivers/vfio/pci/vfio_pci_common.c | 17 +++++++++++++++--
include/linux/vfio_pci_common.h | 4 +++-
samples/vfio-mdev-pci/vfio_mdev_pci.c | 10 +++++-----
4 files changed, 28 insertions(+), 13 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index 704766714c11..1e9d6e4e9c81 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -58,14 +58,14 @@ static void vfio_pci_release(void *device_data)
{
struct vfio_pci_device *vdev = device_data;
- mutex_lock(&vdev->reflck->lock);
+ vfio_pci_reflck_lock(vdev);
if (!(--vdev->refcnt)) {
vfio_spapr_pci_eeh_release(vdev->pdev);
vfio_pci_disable(vdev);
}
- mutex_unlock(&vdev->reflck->lock);
+ vfio_pci_reflck_unlock(vdev);
module_put(THIS_MODULE);
}
@@ -80,7 +80,7 @@ static int vfio_pci_open(void *device_data)
vfio_pci_refresh_config(vdev, nointxmask, disable_idle_d3);
- mutex_lock(&vdev->reflck->lock);
+ vfio_pci_reflck_lock(vdev);
if (!vdev->refcnt) {
ret = vfio_pci_enable(vdev);
@@ -91,7 +91,7 @@ static int vfio_pci_open(void *device_data)
}
vdev->refcnt++;
error:
- mutex_unlock(&vdev->reflck->lock);
+ vfio_pci_reflck_unlock(vdev);
if (ret)
module_put(THIS_MODULE);
return ret;
@@ -200,7 +200,7 @@ static void vfio_pci_remove(struct pci_dev *pdev)
if (!vdev)
return;
- vfio_pci_reflck_put(vdev->reflck);
+ vfio_pci_reflck_put(vdev);
vfio_iommu_group_put(pdev->dev.iommu_group, &pdev->dev);
kfree(vdev->region);
diff --git a/drivers/vfio/pci/vfio_pci_common.c b/drivers/vfio/pci/vfio_pci_common.c
index edda7e4dc2e7..c0462799fc8d 100644
--- a/drivers/vfio/pci/vfio_pci_common.c
+++ b/drivers/vfio/pci/vfio_pci_common.c
@@ -1258,6 +1258,18 @@ EXPORT_SYMBOL_GPL(vfio_pci_err_handlers);
static DEFINE_MUTEX(reflck_lock);
+void vfio_pci_reflck_lock(struct vfio_pci_device *vdev)
+{
+ mutex_lock(&vdev->reflck->lock);
+}
+EXPORT_SYMBOL(vfio_pci_reflck_lock);
+
+void vfio_pci_reflck_unlock(struct vfio_pci_device *vdev)
+{
+ mutex_unlock(&vdev->reflck->lock);
+}
+EXPORT_SYMBOL(vfio_pci_reflck_unlock);
+
static struct vfio_pci_reflck *vfio_pci_reflck_alloc(void)
{
struct vfio_pci_reflck *reflck;
@@ -1333,9 +1345,10 @@ static void vfio_pci_reflck_release(struct kref *kref)
mutex_unlock(&reflck_lock);
}
-void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck)
+void vfio_pci_reflck_put(struct vfio_pci_device *vdev)
{
- kref_put_mutex(&reflck->kref, vfio_pci_reflck_release, &reflck_lock);
+ kref_put_mutex(&vdev->reflck->kref,
+ vfio_pci_reflck_release, &reflck_lock);
}
EXPORT_SYMBOL_GPL(vfio_pci_reflck_put);
diff --git a/include/linux/vfio_pci_common.h b/include/linux/vfio_pci_common.h
index fa572d388111..8090d5469183 100644
--- a/include/linux/vfio_pci_common.h
+++ b/include/linux/vfio_pci_common.h
@@ -120,8 +120,10 @@ extern ssize_t vfio_pci_write(void *device_data, const char __user *buf,
extern int vfio_pci_mmap(void *device_data, struct vm_area_struct *vma);
extern void vfio_pci_request(void *device_data, unsigned int count);
extern void vfio_pci_fill_ids(char *ids, struct pci_driver *driver);
+extern void vfio_pci_reflck_lock(struct vfio_pci_device *vdev);
+extern void vfio_pci_reflck_unlock(struct vfio_pci_device *vdev);
extern int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
-extern void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck);
+extern void vfio_pci_reflck_put(struct vfio_pci_device *vdev);
extern void vfio_pci_probe_power_state(struct vfio_pci_device *vdev);
#endif /* VFIO_PCI_COMMON_H */
diff --git a/samples/vfio-mdev-pci/vfio_mdev_pci.c b/samples/vfio-mdev-pci/vfio_mdev_pci.c
index b180356bb4ee..c98328cb4e3f 100644
--- a/samples/vfio-mdev-pci/vfio_mdev_pci.c
+++ b/samples/vfio-mdev-pci/vfio_mdev_pci.c
@@ -164,7 +164,7 @@ static int vfio_mdev_pci_open(struct mdev_device *mdev)
vfio_pci_refresh_config(vdev, nointxmask, disable_idle_d3);
- mutex_lock(&vdev->reflck->lock);
+ vfio_pci_reflck_lock(vdev);
if (!vdev->refcnt) {
ret = vfio_pci_enable(vdev);
@@ -175,7 +175,7 @@ static int vfio_mdev_pci_open(struct mdev_device *mdev)
}
vdev->refcnt++;
error:
- mutex_unlock(&vdev->reflck->lock);
+ vfio_pci_reflck_unlock(vdev);
if (!ret)
pr_info("Succeeded to open mdev: %s on pf: %s\n",
dev_name(mdev_dev(mdev)), dev_name(&pmdev->vdev->pdev->dev));
@@ -195,14 +195,14 @@ static void vfio_mdev_pci_release(struct mdev_device *mdev)
pr_info("Release mdev: %s on pf: %s\n",
dev_name(mdev_dev(mdev)), dev_name(&pmdev->vdev->pdev->dev));
- mutex_lock(&vdev->reflck->lock);
+ vfio_pci_reflck_lock(vdev);
if (!(--vdev->refcnt)) {
vfio_spapr_pci_eeh_release(vdev->pdev);
vfio_pci_disable(vdev);
}
- mutex_unlock(&vdev->reflck->lock);
+ vfio_pci_reflck_unlock(vdev);
module_put(THIS_MODULE);
}
@@ -341,7 +341,7 @@ static void vfio_mdev_pci_driver_remove(struct pci_dev *pdev)
if (!vdev)
return;
- vfio_pci_reflck_put(vdev->reflck);
+ vfio_pci_reflck_put(vdev);
kfree(vdev->region);
mutex_destroy(&vdev->ioeventfds_lock);
next prev parent reply other threads:[~2020-01-09 22:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 12:01 [PATCH v4 00/12] vfio_pci: wrap pci device as a mediated device Liu Yi L
2020-01-07 12:01 ` [PATCH v4 01/12] vfio_pci: refine user config reference in vfio-pci module Liu Yi L
2020-01-09 22:48 ` Alex Williamson
2020-01-16 12:19 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 02/12] vfio_pci: move vfio_pci_is_vga/vfio_vga_disabled to header file Liu Yi L
2020-01-15 10:43 ` Cornelia Huck
2020-01-16 12:46 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 03/12] vfio_pci: refine vfio_pci_driver reference in vfio_pci.c Liu Yi L
2020-01-09 22:48 ` Alex Williamson
2020-01-10 7:35 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 04/12] vfio_pci: make common functions be extern Liu Yi L
2020-01-15 10:56 ` Cornelia Huck
2020-01-16 12:48 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 05/12] vfio_pci: duplicate vfio_pci.c Liu Yi L
2020-01-15 11:03 ` Cornelia Huck
2020-01-15 15:12 ` Alex Williamson
2020-01-07 12:01 ` [PATCH v4 06/12] vfio_pci: shrink vfio_pci_common.c Liu Yi L
2020-01-07 12:01 ` [PATCH v4 07/12] vfio_pci: shrink vfio_pci.c Liu Yi L
2020-01-08 11:24 ` kbuild test robot
2020-01-09 22:48 ` Alex Williamson
2020-01-16 12:42 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 08/12] vfio_pci: duplicate vfio_pci_private.h to include/linux Liu Yi L
2020-01-07 12:01 ` [PATCH v4 09/12] vfio: split vfio_pci_private.h into two files Liu Yi L
2020-01-09 22:48 ` Alex Williamson [this message]
2020-01-16 11:59 ` Liu, Yi L
2020-01-07 12:01 ` [PATCH v4 10/12] vfio: build vfio_pci_common.c into a kernel module Liu Yi L
2020-01-07 12:01 ` [PATCH v4 11/12] samples: add vfio-mdev-pci driver Liu Yi L
2020-01-09 22:48 ` Alex Williamson
2020-01-16 12:33 ` Liu, Yi L
2020-01-16 21:24 ` Alex Williamson
2020-01-18 14:25 ` Liu, Yi L
2020-01-20 21:07 ` Alex Williamson
2020-01-21 7:43 ` Tian, Kevin
2020-01-21 8:43 ` Yan Zhao
2020-01-21 20:04 ` Alex Williamson
2020-01-21 21:54 ` Yan Zhao
2020-01-23 23:33 ` Alex Williamson
2020-01-31 2:26 ` Yan Zhao
2020-01-15 12:30 ` Cornelia Huck
2020-01-16 13:23 ` Liu, Yi L
2020-01-16 17:40 ` Cornelia Huck
2020-01-18 14:23 ` Liu, Yi L
2020-01-20 8:55 ` Cornelia Huck
2020-01-07 12:01 ` [PATCH v4 12/12] samples: refine " Liu Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109154837.278274f7@w520.home \
--to=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).