Re: [kvm-unit-tests PATCH 0/3] Add support for external tests and litmus7 documentation

From: Andrew Jones <drjones@redhat.com>
To: Nikos Nikoleris <nikos.nikoleris@arm.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	alexandru.elisei@arm.com, Jade Alglave <Jade.Alglave@arm.com>,
	maranget <luc.maranget@inria.fr>
Subject: Re: [kvm-unit-tests PATCH 0/3] Add support for external tests and litmus7 documentation
Date: Wed, 14 Apr 2021 10:42:16 +0200	[thread overview]
Message-ID: <20210414084216.khko7c7tk2tnu6bw@kamzik.brq.redhat.com> (raw)
In-Reply-To: <aaabf2d9-ecea-8665-f43b-d3382963ff5a@arm.com>

On Tue, Apr 13, 2021 at 05:52:37PM +0100, Nikos Nikoleris wrote:
> On 24/03/2021 17:13, Nikos Nikoleris wrote:
> > This set of patches makes small changes to the build system to allow
> > easy integration of tests not included in the repository. To this end,
> > it adds a parameter to the configuration script `--ext-dir=DIR` which
> > will instruct the build system to include the Makefile in
> > DIR/Makefile. The external Makefile can then add extra tests,
> > link object files and modify/extend flags.
> > 
> > In addition, to demonstrate how we can use this functionality, a
> > README file explains how to use litmus7 to generate the C code for
> > litmus tests and link with kvm-unit-tests to produce flat files.
> > 
> > Note that currently, litmus7 produces its own independent Makefile as
> > an intermediate step. Once this set of changes is committed, litmus7
> > will be modifed to make use hook to specify external tests and
> > leverage the build system to build the external tests
> > (https://github.com/relokin/herdtools7/commit/8f23eb39d25931c2c34f4effa096df58547a3bb4).
> > 
> 
> Just wanted to add that if anyone's interested in trying out this series
> with litmus7 I am very happy to help. Any feedback on this series or the way
> we use kvm-unit-tests would be very welcome!

Hi Nikos,

It's on my TODO to play with this. I just haven't had a chance yet. I'm
particularly slow right now because I'm in the process of handling a
switch of my email server from one type to another, requiring rewrites
of filters, new mail synchronization methods, and, in general, lots of
pain... Hopefully by the end of this week all will be done. Then, I can
start ignoring emails on purpose again, instead of due to the fact that
I can't find them :-)

Thanks,
drew

> 
> Thanks,
> 
> Nikos
> 
> > Nikos Nikoleris (3):
> >    arm/arm64: Avoid wildcard in the arm_clean recipe of the Makefile
> >    arm/arm64: Add a way to specify an external directory with tests
> >    README: Add a guide of how to run tests with litmus7
> > 
> >   configure           |   7 +++
> >   arm/Makefile.common |  11 +++-
> >   README.litmus7.md   | 125 ++++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 141 insertions(+), 2 deletions(-)
> >   create mode 100644 README.litmus7.md
> > 
> 