From: Hyman Huang <huangy81@chinatelecom.cn>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v1 2/6] KVM: introduce dirty_pages into CPUState
Date: Wed, 2 Jun 2021 08:27:19 +0800 [thread overview]
Message-ID: <2749938b-f775-ec5a-6ac5-d59cde656999@chinatelecom.cn> (raw)
In-Reply-To: <YLbAoEWOE+no+a7H@t490s>
在 2021/6/2 7:20, Peter Xu 写道:
> On Tue, Jun 01, 2021 at 01:04:06AM +0800, huangy81@chinatelecom.cn wrote:
>> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
>> index 044f668a6e..973c193501 100644
>> --- a/include/hw/core/cpu.h
>> +++ b/include/hw/core/cpu.h
>> @@ -375,6 +375,8 @@ struct CPUState {
>> struct kvm_run *kvm_run;
>> struct kvm_dirty_gfn *kvm_dirty_gfns;
>> uint32_t kvm_fetch_index;
>> + uint64_t dirty_pages;
>> + bool stat_dirty_pages;
>
> Shall we make this bool a global one? As I don't think we'll be able to only
> enable it on a subset of cpus?
Yes, it's a reasonable advice, i'll apply this on the next version
>
--
Best regard
Hyman Huang(黄勇)
next prev parent reply other threads:[~2021-06-02 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 17:02 [PATCH v1 0/6] support dirtyrate at the granualrity of vcpu huangy81
2021-05-31 17:03 ` [PATCH v1 1/6] KVM: add kvm_dirty_ring_enabled function huangy81
2021-05-31 17:04 ` [PATCH v1 2/6] KVM: introduce dirty_pages into CPUState huangy81
2021-06-01 23:20 ` Peter Xu
2021-06-02 0:27 ` Hyman Huang [this message]
2021-06-02 1:26 ` Peter Xu
2021-05-31 17:05 ` [PATCH v1 3/6] migration/dirtyrate: add vcpu option for qmp calc-dirty-rate huangy81
2021-05-31 17:05 ` [PATCH v1 4/6] migration/dirtyrate: adjust struct DirtyRateStat huangy81
2021-05-31 17:05 ` [PATCH v1 5/6] migration/dirtyrate: check support of calculation for vcpu huangy81
2021-05-31 17:06 ` [PATCH v1 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81
2021-06-01 21:54 ` [PATCH v1 0/6] support dirtyrate at the granualrity of vcpu Peter Xu
2021-06-02 0:51 ` Hyman Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2749938b-f775-ec5a-6ac5-d59cde656999@chinatelecom.cn \
--to=huangy81@chinatelecom.cn \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).