From: Pierre Morel <pmorel@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits
Date: Mon, 2 Dec 2019 17:52:48 +0100 [thread overview]
Message-ID: <2f1383bf-15f0-b2f5-96d4-a4a443f33a96@linux.ibm.com> (raw)
In-Reply-To: <3ce5d72d-ed1d-c689-a13f-6f409d085df7@redhat.com>
On 2019-12-02 12:17, David Hildenbrand wrote:
> On 02.12.19 12:11, Janosch Frank wrote:
>> On 11/28/19 3:36 PM, David Hildenbrand wrote:
>>> On 28.11.19 13:46, Pierre Morel wrote:
>>>> Let's define the PSW bits explicitly, it will clarify their
>>>> usage.
>>>>
>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>> ---
>>>> lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++
>>>> lib/s390x/asm/arch_def.h | 6 ++----
>>>
>>> I'm sorry, but I don't really see a reason to move these 4/5 defines to
>>> a separate header. Can you just keep them in arch_def.h and extend?
>>>
>>> (none of your other patches touch arch_bits.h - and it is somewhat a
>>> weird name. Where to put something new: arch_def.h or arch_bits.h? I
>>> would have understood "psw.h", but even that, I don't consider necessary)
>>>
>>
>> On a related note:
>> I'd still like to split up the file soonish, maybe moving the functions
>> into a new file?
>>
>> @Thomas/David: What's your opinion on that?
>
> Sure, as long as the file header is not longer as its actual content :D
>
No problem for me.
What should the file header be?
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2019-12-02 16:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:45 [kvm-unit-tests PATCH v2 0/9] s390x: Testing the Channel Subsystem I/O Pierre Morel
2019-11-28 12:45 ` [kvm-unit-tests PATCH v2 1/9] s390x: saving regs for interrupts Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits Pierre Morel
2019-11-28 14:36 ` David Hildenbrand
2019-11-28 19:16 ` Pierre Morel
2019-11-28 19:48 ` David Hildenbrand
2019-11-29 13:04 ` Pierre Morel
2019-12-02 11:11 ` Janosch Frank
2019-12-02 11:17 ` David Hildenbrand
2019-12-02 16:52 ` Pierre Morel [this message]
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 3/9] s390x: irq: make IRQ handler weak Pierre Morel
2019-11-29 12:01 ` David Hildenbrand
2019-12-02 10:41 ` Thomas Huth
2019-12-02 16:55 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 4/9] s390x: export the clock get_clock_ms() utility Pierre Morel
2019-11-29 12:03 ` David Hildenbrand
2019-11-29 13:04 ` Pierre Morel
2019-12-02 11:13 ` Janosch Frank
2019-12-02 17:03 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 5/9] s390x: Library resources for CSS tests Pierre Morel
2019-12-02 14:06 ` Cornelia Huck
2019-12-02 17:33 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 6/9] s390x: css: stsch, enumeration test Pierre Morel
2019-12-02 14:22 ` Cornelia Huck
2019-12-02 17:53 ` Pierre Morel
2019-12-02 18:15 ` Cornelia Huck
2019-12-02 18:33 ` Pierre Morel
2019-12-02 19:49 ` Cornelia Huck
2019-12-03 8:43 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 7/9] s390x: css: msch, enable test Pierre Morel
2019-12-02 14:30 ` Cornelia Huck
2019-12-02 17:55 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 8/9] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2019-12-02 14:55 ` Cornelia Huck
2019-12-02 18:18 ` Pierre Morel
2019-12-02 19:54 ` Cornelia Huck
2019-12-03 8:58 ` Pierre Morel
2019-11-28 12:46 ` [kvm-unit-tests PATCH v2 9/9] s390x: css: ping pong Pierre Morel
2019-12-02 15:03 ` Cornelia Huck
2019-12-02 18:25 ` Pierre Morel
2019-12-06 14:18 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1383bf-15f0-b2f5-96d4-a4a443f33a96@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).