From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: Drew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] scripts: Fix the check whether testname is in the only_tests list
Date: Wed, 1 Jul 2020 11:43:03 +0200 [thread overview]
Message-ID: <3b521930-4cec-e7d5-0d30-9d79684c9949@redhat.com> (raw)
In-Reply-To: <c7485f32-d3bb-81f2-786a-3716f0a32800@redhat.com>
On 01/07/20 10:57, Thomas Huth wrote:
>>>
>>
>> Simpler: grep -q " $testname " <<< " $only_tests "
>
> That doesn't work:
>
> $ ./run_tests.sh ioapic-split
> PASS apic-split (53 tests)
> PASS ioapic-split (19 tests)
> PASS apic (53 tests)
> PASS ioapic (26 tests)
>
> ... because the $testname comes from unittests.cfg and $only_tests is
> the list that has been given on the command line. It would maybe work if
> the check was the other way round ... but that would require to rewrite
> quite a bit of the script logic...
It works here. I'll send a patch.
Paolo
> By the way, you can currently also run "./run_test.sh badname" and it
> does *not* complain that "badname" is an illegal test name...
next prev parent reply other threads:[~2020-07-01 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 8:37 [kvm-unit-tests PATCH] scripts: Fix the check whether testname is in the only_tests list Thomas Huth
2020-07-01 8:51 ` Paolo Bonzini
2020-07-01 8:57 ` Thomas Huth
2020-07-01 9:43 ` Paolo Bonzini [this message]
2020-07-01 9:55 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b521930-4cec-e7d5-0d30-9d79684c9949@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).