From: David Hildenbrand <david@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org
Cc: thuth@redhat.com, mihajlov@linux.ibm.com, cohuck@redhat.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Add new reset vcpu API
Date: Fri, 29 Nov 2019 15:48:41 +0100 [thread overview]
Message-ID: <487af903-bb8c-a7c5-b81d-dc0ce1bb7b75@redhat.com> (raw)
In-Reply-To: <708d16c2-fa18-8ab9-afb5-44b5af638cb4@de.ibm.com>
On 29.11.19 15:39, Christian Borntraeger wrote:
>
>
> On 29.11.19 15:38, Janosch Frank wrote:
> [...]
>>>>> As we now have two interfaces to achieve the same thing (initial reset),
>>>>> I do wonder if we should simply introduce
>>>>>
>>>>> KVM_S390_NORMAL_RESET
>>>>> KVM_S390_CLEAR_RESET
>>>>>
>>>>> instead ...
>>>>>
>>>>> Then you can do KVM_S390_NORMAL_RESET for the bugfix and
>>>>> KVM_S390_CLEAR_RESET later for PV.
>>>>>
>>>>> Does anything speak against that?
>>>>
>>>> Apart from loosing one more ioctl number probably not
>>>
>>> Do we care? (I think not, but maybe I am missing something :) )
>>>
>>
>> I don't, maybe somebody else does
>> Btw. I'm struggling to find a good name for the capability:
>> KVM_CAP_S390_VCPU_ADDITIONAL_RESETS ?
>
> KVM_CAP_S390_VCPU_RESETS ?
Either that or two separate ones if you're not going to introduce them
at the same time ...
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-11-29 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 14:21 [PATCH] KVM: s390: Add new reset vcpu API Janosch Frank
2019-11-29 14:31 ` David Hildenbrand
2019-11-29 14:33 ` Janosch Frank
2019-11-29 14:33 ` David Hildenbrand
2019-11-29 14:38 ` Janosch Frank
2019-11-29 14:39 ` Christian Borntraeger
2019-11-29 14:48 ` David Hildenbrand [this message]
2019-11-29 14:57 ` Janosch Frank
2019-12-02 8:54 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487af903-bb8c-a7c5-b81d-dc0ce1bb7b75@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).