From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Christoph Hellwig <hch@lst.de>,
torvalds@linux-foundation.org
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "KVM: x86: enable -Werror"
Date: Thu, 27 Feb 2020 07:41:50 +0100 [thread overview]
Message-ID: <5f31e38e-2f78-7919-7c60-a1761b9abb2e@redhat.com> (raw)
In-Reply-To: <87v9ns1z79.fsf@mpe.ellerman.id.au>
On 27/02/20 04:33, Michael Ellerman wrote:
> We've had -Werror enabled by default on powerpc for over 10 years, and
> haven't had many complaints. Possibly that's just because no one builds
> powerpc kernels ...
I looked for other cases of -Werror being always on in Linux before
writing this patch. There are both unconditional cases and others like
PPC where it's governed by Kconfig.
I will add a Kconfig for now. It probably should be made global instead
of having a dozen different Kconfig symbols.
kvm_timer_init should be fixed, though.
Paolo
> The key thing is that it's configurable, so if it does break the build
> for someone they can just turn it off. It's also off by default for
> allyes/allmod builds because the user-selectable option disables
> -Werror, eg:
prev parent reply other threads:[~2020-02-27 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 15:39 [PATCH] Revert "KVM: x86: enable -Werror" Christoph Hellwig
2020-02-27 3:33 ` Michael Ellerman
2020-02-27 6:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f31e38e-2f78-7919-7c60-a1761b9abb2e@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).