kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 kvm-unit-tests 0/2] fix long division routines for ARM eabi
Date: Wed, 12 May 2021 15:04:17 +0100	[thread overview]
Message-ID: <6ae326a1-361c-0cbe-66f7-b02efd78cdb3@arm.com> (raw)
In-Reply-To: <20210512105440.748153-1-pbonzini@redhat.com>

Hello,

On 5/12/21 11:54 AM, Paolo Bonzini wrote:

> As reported by Alexandru, ARM follows a different convention than
> x86 so it needs __aeabi_ldivmod and __aeabi_uldivmod.  Because
> it does not use __divdi3 and __moddi3, it also needs __divmoddi4
> to build the eabi function upon.
>
> Paolo
>
> v1->v2: fix __divmoddi4, make sure -DTEST covers it
>
> Paolo Bonzini (2):
>   libcflat: clean up and complete long division routines
>   arm: add eabi version of 64-bit division functions
>
>  arm/Makefile.arm  |  1 +
>  lib/arm/ldivmod.S | 32 ++++++++++++++++++++++++++++++++
>  lib/ldiv32.c      | 40 ++++++++++++++++++++++++----------------
>  3 files changed, 57 insertions(+), 16 deletions(-)
>  create mode 100644 lib/arm/ldivmod.S
>
I ran the arm (compiled with arm-none-eabi-gcc and arm-linux-gnu-gcc) and arm64
tests under QEMU TCG, and everything worked as expected.

I ran the arm (compiled with both toolchains) and arm64 tests under qemu and
kvmtool on a Rockpro64 dev board, again I didn't encounter any issues. So for the
entire series:

Tested-by: Alexandru Elisei <alexandru.elisei@arm.com>

Thanks,

Alex


      parent reply	other threads:[~2021-05-12 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 10:54 [PATCH v2 kvm-unit-tests 0/2] fix long division routines for ARM eabi Paolo Bonzini
2021-05-12 10:54 ` [PATCH v2 kvm-unit-tests 1/2] libcflat: clean up and complete long division routines Paolo Bonzini
2021-05-12 13:44   ` Alexandru Elisei
2021-05-12 10:54 ` [PATCH v2 kvm-unit-tests 2/2] arm: add eabi version of 64-bit division functions Paolo Bonzini
2021-05-12 13:44   ` Alexandru Elisei
2021-05-12 13:51     ` Paolo Bonzini
2021-05-12 14:04       ` Alexandru Elisei
2021-05-12 14:04 ` Alexandru Elisei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ae326a1-361c-0cbe-66f7-b02efd78cdb3@arm.com \
    --to=alexandru.elisei@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).