From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE686C43603 for ; Wed, 18 Dec 2019 22:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABB0220717 for ; Wed, 18 Dec 2019 22:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LBsr8JY8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbfLRWhg (ORCPT ); Wed, 18 Dec 2019 17:37:36 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:45442 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726518AbfLRWhg (ORCPT ); Wed, 18 Dec 2019 17:37:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576708655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nyKH+GG9maQ/CDdFzTvDDSeKNGA19czyfBwyFBCr+TI=; b=LBsr8JY8MijAQhcTV37vyfMEcc58qGcVOA71/gUHp+GWkuGz7sNhmcklJ0E7AkcDoj/xwx mjT7vNhMkoKaXGq+W4sPeZ3lk2lx67tT+K0egxbLQl3AB9z6YP7J7T2XJP8BPggQ/+cmdn lfKv2m9kqJW6Vy3+avSc2UpBtwNMdzc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-cW-aFMbYOyi2zlh3V-xNIg-1; Wed, 18 Dec 2019 17:37:34 -0500 X-MC-Unique: cW-aFMbYOyi2zlh3V-xNIg-1 Received: by mail-wm1-f72.google.com with SMTP id g26so932620wmk.6 for ; Wed, 18 Dec 2019 14:37:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nyKH+GG9maQ/CDdFzTvDDSeKNGA19czyfBwyFBCr+TI=; b=jtE4e6eIMJxwKGhidTRtRR82Sid1bpsSJ1KvvMw3Cw8dBeL5Gk0739zq4h6JTwQMW3 A0u9Us7yMMA52xsX8k1Qeu1pISFxcM9dJ5KHRQOPxNw3V4je+9TBKE6dOPjgU7mXu2O/ QSIjLiit7vnEvHB8c11CcQuxmCY+c0alS0UyNzD7R034e+pI5tDRwqVnIZN6idOY23Yt m0U9BdsOAucGtSFAG1N/oQrwp4uNAbQONU98mGgBGyVtsm7YAB61UyUMHzsjamKac2Al XB7HXdT7A9eTsty6F/D19eyc/7QBmPP6D66z2aAh0J/Y8pGlOPy7c6hcfTpWsa8x65Ub XotA== X-Gm-Message-State: APjAAAUvI4hTrWLxatzLdOXN9iIgmRxyw99s/9AhuiecS+sAWO3iwXaa 3OVZ9kiXFKVD73+Kj+PxN8IFmDxR5wixdsPk/PlMMTDYkJWMruFlB33JlY7TQ9ofdKQrBjiy0z8 UfCRHOv1TT4+Q X-Received: by 2002:a1c:770e:: with SMTP id t14mr6364242wmi.101.1576708653479; Wed, 18 Dec 2019 14:37:33 -0800 (PST) X-Google-Smtp-Source: APXvYqybTuTVWzLqRLznVN+zxwbM+9s5N0zqn7/jFC4IyZ6tn5C5ybLXwXLHlPz+5TyRSgXHUStnoA== X-Received: by 2002:a1c:770e:: with SMTP id t14mr6364216wmi.101.1576708653263; Wed, 18 Dec 2019 14:37:33 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:ac09:bce1:1c26:264c? ([2001:b07:6468:f312:ac09:bce1:1c26:264c]) by smtp.gmail.com with ESMTPSA id w8sm4110638wmm.0.2019.12.18.14.37.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2019 14:37:32 -0800 (PST) Subject: Re: [PATCH RFC 04/15] KVM: Implement ring-based dirty memory tracking To: Sean Christopherson , Peter Xu Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "Dr . David Alan Gilbert" , Vitaly Kuznetsov , Alex Williamson , "Tian, Kevin" References: <20191210155259.GD3352@xz-x1> <3e6cb5ec-66c0-00ab-b75e-ad2beb1d216d@redhat.com> <20191215172124.GA83861@xz-x1> <20191216185454.GG83861@xz-x1> <815923d9-2d48-2915-4acb-97eb90996403@redhat.com> <20191217162405.GD7258@xz-x1> <20191218215857.GE26669@xz-x1> <20191218222420.GH25201@linux.intel.com> From: Paolo Bonzini Message-ID: <77b497c8-3939-58d1-166f-6c862d3a8d5b@redhat.com> Date: Wed, 18 Dec 2019 23:37:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191218222420.GH25201@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 18/12/19 23:24, Sean Christopherson wrote: > I've lost track of the problem you're trying to solve, but if you do > something like "vcpu_smm=false", explicitly pass an address space ID > instead of hardcoding x86 specific SMM crud, e.g. > > kvm_vcpu_write*(..., as_id=0); And the point of having kvm_vcpu_* vs. kvm_write_* was exactly to not having to hardcode the address space ID. If anything you could add a __kvm_vcpu_write_* API that takes vcpu+as_id, but really I'd prefer to keep kvm_get_running_vcpu() for now and then it can be refactored later. There are already way too many memory r/w APIs... Paolo