From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
kvm@vger.kernel.org, Tao Xu <tao3.xu@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally
Date: Thu, 21 May 2020 12:33:29 +0800 [thread overview]
Message-ID: <81228a0e-7797-4f34-3d6d-5b0550c10a8f@intel.com> (raw)
In-Reply-To: <b8ca9ea1-2958-3ab4-2e86-2edbee1ca9d9@redhat.com>
On 5/21/2020 5:05 AM, Paolo Bonzini wrote:
> On 20/05/20 18:07, Maxim Levitsky wrote:
>> This msr is only available when the host supports WAITPKG feature.
>>
>> This breaks a nested guest, if the L1 hypervisor is set to ignore
>> unknown msrs, because the only other safety check that the
>> kernel does is that it attempts to read the msr and
>> rejects it if it gets an exception.
>>
>> Fixes: 6e3ba4abce KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL
>>
>> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
>> ---
>> arch/x86/kvm/x86.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index fe3a24fd6b263..9c507b32b1b77 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -5314,6 +5314,10 @@ static void kvm_init_msr_list(void)
>> if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_EVENTSEL0 >=
>> min(INTEL_PMC_MAX_GENERIC, x86_pmu.num_counters_gp))
>> continue;
>> + break;
>> + case MSR_IA32_UMWAIT_CONTROL:
>> + if (!kvm_cpu_cap_has(X86_FEATURE_WAITPKG))
>> + continue;
>> default:
>> break;
>> }
>
> The patch is correct, and matches what is done for the other entries of
> msrs_to_save_all. However, while looking at it I noticed that
> X86_FEATURE_WAITPKG is actually never added, and that is because it was
> also not added to the supported CPUID in commit e69e72faa3a0 ("KVM: x86:
> Add support for user wait instructions", 2019-09-24), which was before
> the kvm_cpu_cap mechanism was added.
>
> So while at it you should also fix that. The right way to do that is to
> add a
>
> if (vmx_waitpkg_supported())
> kvm_cpu_cap_check_and_set(X86_FEATURE_WAITPKG);
+ Tao
I remember there is certainly some reason why we don't expose WAITPKG to
guest by default.
Tao, please help clarify it.
Thanks,
-Xiaoyao
>
> in vmx_set_cpu_caps.
>
> Thanks,
>
> Paolo
>
next prev parent reply other threads:[~2020-05-21 4:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 16:07 [PATCH 0/2] Fix breakage from adding MSR_IA32_UMWAIT_CONTROL Maxim Levitsky
2020-05-20 16:07 ` [PATCH 1/2] kvm: cosmetic: remove wrong braces in kvm_init_msr_list switch Maxim Levitsky
2020-05-20 16:23 ` Vitaly Kuznetsov
2020-05-20 16:07 ` [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally Maxim Levitsky
2020-05-20 16:33 ` Vitaly Kuznetsov
2020-05-20 16:56 ` Maxim Levitsky
2020-05-20 17:15 ` Vitaly Kuznetsov
2020-05-20 17:39 ` Maxim Levitsky
2020-05-21 8:03 ` Xiaoyao Li
2020-05-20 21:05 ` Paolo Bonzini
2020-05-20 21:09 ` Maxim Levitsky
2020-05-21 4:33 ` Xiaoyao Li [this message]
2020-05-21 5:28 ` Tao Xu
2020-05-21 6:37 ` Xiaoyao Li
2020-05-21 6:44 ` Tao Xu
2020-05-21 8:40 ` Paolo Bonzini
2020-06-30 13:41 ` Maxim Levitsky
2020-05-21 8:24 ` Paolo Bonzini
2020-05-23 16:14 [PATCH 0/2] Fix issue with not starting nesting guests on my system Maxim Levitsky
2020-05-23 16:14 ` [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally Maxim Levitsky
2020-05-27 1:21 ` Sean Christopherson
2020-05-27 15:17 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81228a0e-7797-4f34-3d6d-5b0550c10a8f@intel.com \
--to=xiaoyao.li@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).