From: "Andy Lutomirski" <luto@kernel.org>
To: "Borislav Petkov" <bp@alien8.de>,
"Ashish Kalra" <Ashish.Kalra@amd.com>,
"Sean Christopherson" <seanjc@google.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Joerg Roedel" <joro@8bytes.org>,
thomas.lendacky@amd.com,
"the arch/x86 maintainers" <x86@kernel.org>,
"kvm list" <kvm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
srutherford@google.com, venu.busireddy@oracle.com,
brijesh.singh@amd.com
Subject: Re: [PATCH v2 2/4] mm: x86: Invoke hypercall when page encryption status is changed
Date: Wed, 19 May 2021 16:29:37 -0700 [thread overview]
Message-ID: <86701a5e-87b5-4e73-9b7a-557d8c855f89@www.fastmail.com> (raw)
In-Reply-To: <YJvU+RAvetAPT2XY@zn.tnic>
On Wed, May 12, 2021, at 6:15 AM, Borislav Petkov wrote:
> On Fri, Apr 23, 2021 at 03:58:43PM +0000, Ashish Kalra wrote:
> > +static inline void notify_page_enc_status_changed(unsigned long pfn,
> > + int npages, bool enc)
> > +{
> > + PVOP_VCALL3(mmu.notify_page_enc_status_changed, pfn, npages, enc);
> > +}
>
> Now the question is whether something like that is needed for TDX, and,
> if so, could it be shared by both.
The TDX MapGPA call can fail, and presumably it will fail if the page is not sufficiently quiescent from the host's perspective. It seems like a mistake to me to have a KVM-specific hypercall for this that cannot cleanly fail.
next prev parent reply other threads:[~2021-05-19 23:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 15:57 [PATCH v2 0/4] Add guest support for SEV live migration Ashish Kalra
2021-04-23 15:58 ` [PATCH v2 1/4] KVM: x86: invert KVM_HYPERCALL to default to VMMCALL Ashish Kalra
2021-04-23 16:31 ` Jim Mattson
2021-04-23 17:44 ` Sean Christopherson
2021-04-23 15:58 ` [PATCH v2 2/4] mm: x86: Invoke hypercall when page encryption status is changed Ashish Kalra
2021-05-12 13:15 ` Borislav Petkov
2021-05-12 15:51 ` Sean Christopherson
2021-05-12 16:23 ` Borislav Petkov
2021-05-13 6:57 ` Ashish Kalra
2021-05-13 8:40 ` Paolo Bonzini
2021-05-13 13:49 ` Tom Lendacky
2021-05-13 4:34 ` Ashish Kalra
2021-05-14 7:33 ` Borislav Petkov
2021-05-14 8:03 ` Paolo Bonzini
2021-05-14 9:05 ` Ashish Kalra
2021-05-14 9:34 ` Borislav Petkov
2021-05-14 10:05 ` Ashish Kalra
2021-05-14 10:38 ` Borislav Petkov
2021-05-18 2:01 ` Steve Rutherford
2021-05-19 12:06 ` Ashish Kalra
2021-05-19 13:44 ` Paolo Bonzini
2021-05-14 9:57 ` Paolo Bonzini
2021-05-14 9:24 ` Borislav Petkov
2021-05-14 9:33 ` Ashish Kalra
2021-05-19 23:29 ` Andy Lutomirski [this message]
2021-05-19 23:44 ` Sean Christopherson
2021-04-23 15:59 ` [PATCH v2 3/4] EFI: Introduce the new AMD Memory Encryption GUID Ashish Kalra
2021-05-12 13:19 ` Borislav Petkov
2021-05-12 14:53 ` Ard Biesheuvel
2021-05-13 4:36 ` Ashish Kalra
2021-04-23 15:59 ` [PATCH v2 4/4] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature Ashish Kalra
2021-04-30 7:19 ` [PATCH v2 0/4] Add guest support for SEV live migration Ashish Kalra
2021-04-30 7:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86701a5e-87b5-4e73-9b7a-557d8c855f89@www.fastmail.com \
--to=luto@kernel.org \
--cc=Ashish.Kalra@amd.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=srutherford@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=venu.busireddy@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).