From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests] runtime.bash: skip test when checked file doesn't exist
Date: Thu, 15 Oct 2020 10:36:20 +0200 [thread overview]
Message-ID: <87o8l36g3f.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <849201e6-2c21-154d-cb5c-712bd9c3d3b4@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 14/10/2020 17.42, Vitaly Kuznetsov wrote:
>> Currently, we have the following check condition in x86/unittests.cfg:
>>
>> check = /sys/module/kvm_intel/parameters/allow_smaller_maxphyaddr=Y
>>
>> the check, however, passes successfully on AMD because the checked file
>> is just missing. This doesn't sound right, reverse the check: fail
>> if the content of the file doesn't match the expectation or if the
>> file is not there.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> ---
>> scripts/runtime.bash | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> index 3121c1ffdae8..f94c094de03b 100644
>> --- a/scripts/runtime.bash
>> +++ b/scripts/runtime.bash
>> @@ -118,7 +118,10 @@ function run()
>> for check_param in "${check[@]}"; do
>> path=${check_param%%=*}
>> value=${check_param#*=}
>> - if [ -f "$path" ] && [ "$(cat $path)" != "$value" ]; then
>> + if [ -z "$path" ]; then
>> + continue
>> + fi
>
> That runtime.bash script seems to use spaces for indentation, not tabs ...
> so could you please use spaces for your patch, too?
>
Yea, trusted my editior to do the right thing and it let me down... v2
is coming!
--
Vitaly
prev parent reply other threads:[~2020-10-15 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 15:42 [PATCH kvm-unit-tests] runtime.bash: skip test when checked file doesn't exist Vitaly Kuznetsov
2020-10-14 15:54 ` Thomas Huth
2020-10-15 8:36 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8l36g3f.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).