From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B636DC3A5A3 for ; Sat, 24 Aug 2019 04:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BE232054F for ; Sat, 24 Aug 2019 04:45:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Zin80qcM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725917AbfHXEpo (ORCPT ); Sat, 24 Aug 2019 00:45:44 -0400 Received: from mail-eopbgr80070.outbound.protection.outlook.com ([40.107.8.70]:6049 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725379AbfHXEpn (ORCPT ); Sat, 24 Aug 2019 00:45:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=har4WHCvP4HtKSDD4IX7w5Y8fe3BZmimwoo1I45yOJQKnonJRbP78tSaTdml6gvIq53HpQBceap1AEcYjvkWiQy7Sob1dWO4PyK7LZqIwOyxEz9pQTUwbTrhO42lHsri/FCO0gxi4l+2kGeE/uH8oof7NkLcit+QHxOoit4jfFmdNaWXQ61jb8JqgVyRoUT5GmYmGe59dkH9L8N56zIyCoHoz8mUtXvWb5pZbQ7pmvx0bjpUi5ATWJz3dIStKbsc6f04Z0fozwu/MSUJe9uq+kf2cSyExeXfPsDPHxox6iP7rvcYAuYCgBD+5uZhoxDdGPssaI7F6PfiUmfAF6KFww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCUHwGbz/VVxA1+F92cZgCBF30GyVanu2e/qxAZ7ydM=; b=Ig/jzIMnqT55UfQr8fRkukjsPbYNSUOI6LF7NqLF1QzPgU6y8iKP+3YQcNVZRKFEltdTELrXT7/F/nW0OGrTs2CCo3uHdx3amj2AHWb+yYlrB5hq5ntFQ9gH/T2LLsRvfnANrFQPCUjj/PTbhPCeCZGamta4ipJup/3arC5sEvqePW94OsAp/BxDqbBEuFPAwb6hMhF6jqNHDt6BoVKMhhkPU66uPjsEp2fGWCB5cxuoFDPLqfvD7LLp49+pXjSMa4AIWyw9iuZC39uVABhy8BvlKOWfRY8Eygo4apgMLd6dzd3i6StHsccQ3n6WBHFl9XY1C/mKqtmmzg+eYoITsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCUHwGbz/VVxA1+F92cZgCBF30GyVanu2e/qxAZ7ydM=; b=Zin80qcMRB1FYzpsg3th/hw3eqelmQj3Ejqb/jEUrqt8TK/VOdyDduaP0+9NmiTV9v+rtYTohZt0k3GYHkoFraHTPZTn3edoQaUWaPYLrPD+wjtfFpwcGDM46+9mAdjY9MFAo9G5JKuovA4EtaeeepWW1dp682hrhNwt6KinsXE= Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (20.176.214.160) by AM0PR05MB6274.eurprd05.prod.outlook.com (20.179.32.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.20; Sat, 24 Aug 2019 04:45:25 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::216f:f548:1db0:41ea]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::216f:f548:1db0:41ea%6]) with mapi id 15.20.2178.020; Sat, 24 Aug 2019 04:45:25 +0000 From: Parav Pandit To: Parav Pandit , Alex Williamson CC: Jiri Pirko , Jiri Pirko , "David S . Miller" , Kirti Wankhede , Cornelia Huck , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , cjia , "netdev@vger.kernel.org" Subject: RE: [PATCH v2 0/2] Simplify mtty driver and mdev core Thread-Topic: [PATCH v2 0/2] Simplify mtty driver and mdev core Thread-Index: AQHVTfNxjgfwJJG2ZUiuOAmKCwQvf6bx3uKAgAWJU4CAAcVCEIAABCsAgAAWVtCAABCDgIAAzoewgAAqE4CAAECFQIAAFWyAgAAGbNCAABfqAIAAErcwgAjpulCAAJkHAIAAnVNggAAbk4CAAAOYgIAABpwAgAAAVrCAAAfEAIAADNCggAHJU4CAAAIMEIAABiaAgAAA2ACAACadAIAAFGdwgAE42YCAAABasIAAaLIAgAAC1QCAABSugIAAA+pAgAATnYCAAAO7UIAAJVKAgACGAeCAABAIQA== Date: Sat, 24 Aug 2019 04:45:25 +0000 Message-ID: References: <20190820225722.237a57d2@x1.home> <20190822092903.GA2276@nanopsycho.orion> <20190822095823.GB2276@nanopsycho.orion> <20190822121936.GC2276@nanopsycho.orion> <20190823081221.GG2276@nanopsycho.orion> <20190823082820.605deb07@x1.home> <20190823095229.210e1e84@x1.home> <20190823111641.7f928917@x1.home> <20190823134337.37e4b215@x1.home> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [106.51.18.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24082db6-526d-425d-8b6d-08d7284de147 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM0PR05MB6274; x-ms-traffictypediagnostic: AM0PR05MB6274: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0139052FDB x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(189003)(199004)(13464003)(5660300002)(9456002)(486006)(14454004)(4326008)(86362001)(8936002)(81156014)(81166006)(476003)(8676002)(66476007)(7696005)(186003)(66946007)(33656002)(6506007)(53546011)(26005)(102836004)(55236004)(53936002)(74316002)(54906003)(99286004)(6116002)(7736002)(110136005)(11346002)(478600001)(3846002)(6436002)(76176011)(66066001)(316002)(2906002)(256004)(71200400001)(71190400001)(14444005)(446003)(6246003)(52536014)(25786009)(2940100002)(305945005)(55016002)(9686003)(66446008)(66556008)(76116006)(64756008)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB6274;H:AM0PR05MB4866.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: e7jtmWnB549hcmbRZTnKiMSAFv61tnU3SeERshJ6KPPWfxi9u//LwcHD6/SMVOzPKab/VzQMI6/29xQ5bJeE+P7Q7WvUwDMkSFd/vv518BnaKFv51vyjAYne6oAFEsR7THFk2prdX8/fXjgMMOmhDJOvuDD8wYFoR48EIzx5E4zTHnWKEF2sCX2dzyi3wv33NMG2mxmDEvea4vM6rGeIJoQ6Iolvb5rM9AppyGbOnjILeKiHQEtyOqfH66+gwAbpNmmssYkWzzG3bGXpIlmjU7pkafPe+VIChWKrcrAkH6e5N3ehA8sCGM8jH04QkcwR9/tB5JHGR1oQ6bXH/bhtFC5k1UH+u8Lvd/U81mBT6jC3+hVa0m8w4uxUJY8oJ98s2geCFRW7z+3IzaqCb6nQV/dckbwGMkgJQLm9pks5iIo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24082db6-526d-425d-8b6d-08d7284de147 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2019 04:45:25.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xbQ8onFBG7Do4MipSeseDbga8qxCeuFZN9TUwgRREQhnscR80+bJL3Z5FAUkVegpKtuHmsuMuk7tm30ghWpCoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6274 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Alex, > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org owner@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Saturday, August 24, 2019 9:26 AM > To: Alex Williamson > Cc: Jiri Pirko ; Jiri Pirko ; David = S . > Miller ; Kirti Wankhede ; > Cornelia Huck ; kvm@vger.kernel.org; linux- > kernel@vger.kernel.org; cjia ; netdev@vger.kernel.org > Subject: RE: [PATCH v2 0/2] Simplify mtty driver and mdev core > > I don't understand this logic. I'm simply asking that we have a way > > to test the collision behavior without changing the binary. The path > > we're driving towards seems to be making this easier and easier. If > > the vendor can request an alias of a specific length, then a sample > > driver with a module option to set the desired alias length to 1-char m= akes > it trivially easy to induce a collision. > Sure it is easy to test collision, but my point is - mdev core is not sha= 1 test > module. > Hence adding functionality of variable alias length to test collision doe= sn't > make sense. > When the actual user arrives who needs small alias, we will be able to ad= d > additional pieces very easily. My initial thoughts to add parent_ops to have bool flag to generate alias o= r not. However, instead of bool, keeping it unsigned int to say, zero to skip alia= s and non-zero length to convey generate alias. This will serve both the purpose with trivial handling.