From: Stefano Garzarella <sgarzare@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
Michael Tsirkin <mst@redhat.com>, Cindy Lu <lulu@redhat.com>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH V4 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk
Date: Wed, 24 Nov 2021 16:39:16 +0100 [thread overview]
Message-ID: <CAGxU2F622pzZkh8WC7J+jGYu-_ozSDx1Tvvvtw-z52xwC3S38A@mail.gmail.com> (raw)
In-Reply-To: <20210419063326.3748-1-lingshan.zhu@intel.com>
Hi Zhu,
On Mon, Apr 19, 2021 at 8:39 AM Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>
> This series enabled Intel FGPA SmartNIC C5000X-PL virtio-blk for vDPA.
Looking at the IFCVF upstream vDPA driver (with this series applied), it
seems that there is still some cleaning to be done to support virtio-blk
devices:
- ifcvf_vdpa_get_config() and ifcvf_vdpa_set_config() use
`sizeof(struct virtio_net_config)` to check the inputs.
This seems wrong for a virtio-blk device. Maybe we can set the config
size for each device in ifcvf_vdpa_dev_add() and use that field to
check the inputs. We can reuse the same field also in
ifcvf_vdpa_get_config_size().
- Just for make the code more readable we should rename `net_cfg` field
to `device_cfg`in `struct ifcvf_hw`.
What do you think?
Thanks,
Stefano
next prev parent reply other threads:[~2021-11-24 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 6:33 [PATCH V4 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk Zhu Lingshan
2021-04-19 6:33 ` [PATCH V4 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe Zhu Lingshan
2021-04-20 2:56 ` Jason Wang
2021-04-19 6:33 ` [PATCH V4 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA Zhu Lingshan
2021-05-03 8:47 ` Michael S. Tsirkin
2021-05-06 3:11 ` Zhu, Lingshan
2021-04-19 6:33 ` [PATCH V4 3/3] vDPA/ifcvf: get_config_size should return dev specific config size Zhu Lingshan
2021-11-24 15:39 ` Stefano Garzarella [this message]
2021-11-25 2:12 ` [PATCH V4 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGxU2F622pzZkh8WC7J+jGYu-_ozSDx1Tvvvtw-z52xwC3S38A@mail.gmail.com \
--to=sgarzare@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).