From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87561C4363D for ; Wed, 30 Sep 2020 23:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E9C32075F for ; Wed, 30 Sep 2020 23:12:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZPx2WhLM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732105AbgI3XM2 (ORCPT ); Wed, 30 Sep 2020 19:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732091AbgI3XML (ORCPT ); Wed, 30 Sep 2020 19:12:11 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95661C061755 for ; Wed, 30 Sep 2020 16:12:11 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id j2so4441438ioj.7 for ; Wed, 30 Sep 2020 16:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MR1J/wCcy9hPIA8a165EobJ1iSvsAYHQOKsxcC0t/ZM=; b=ZPx2WhLMEsL+yYluidhwYyEFpZN/TyaUEwO8sRM63oQOYIGVvUOWXjFMKP0VqrXwAq mzB5kdZF0W9dEZ8UBcur7v0adPsyrmNyZGl81iLAIwMxekR23Fd6wFB/yI1nzm9QmE+A 8oK19FFbc4ooWqrN3POUzW22gnn2WQvXNPfXPsNINqv57TwhshXkrcRpT4Z6q58lGM+/ jhBSSQGxxVLtbx+q0yRyaf1M0YsuPGLgIP19vuDKXZVs9DpsHzjN0ff08PYX6m3CKTKL QTSXdoPWQt7G7LDZLpPaKkyuJZK+MFEdwKRJEUoo7u9sFzMQV5bozmTnRk+uOzGJ/lqN S/CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MR1J/wCcy9hPIA8a165EobJ1iSvsAYHQOKsxcC0t/ZM=; b=SARu/jYkn37Wx6C+BKM6iHO6YtPw1BkmIwxGOS0Z6tfoEgGy0/HGe7ZVfOfN3I4jEE jIf7CkJtwqnLi/yr7hBXvcSkgzeH+T+SgDsI7fc8nAz5xHxzGY64KOmnRTD/4j/cR4FE mQ33uzW3ghGJsxfX/IdX1aw/UrkPuWEHApMZakGjnNi8ExffapuO1nfgfCtpH5CsJENq 0/jS6MuZppfVxMiPl3+oNElsaPWhZGwn7FOt+DZdN3ByfbWGqlO2bXic90evgnINz3+M aFmv/fxaA1A0gYXqLqCKevvVPQBDM2QLFTXTl4FApdoIZPIAKFZrjD1Fa9hG5vCdekvo QdSw== X-Gm-Message-State: AOAM532Eb5VTFm5g1DBcCrXmtOy6ENKW5Wqkl/OE+02TzUq4hlft6rkH vTq2HAMOrA/hfMDoCTS6vPU+mPTyu7H4gYXyU6GP5Q== X-Google-Smtp-Source: ABdhPJwshOH3BplNx3wbsv2/KZX/xMddVCbwS6IPwGnVnWVW23j4+xqef3UnuHpAOtbj9dRLiD6aYHBzOdklq0RIdQQ= X-Received: by 2002:a6b:610d:: with SMTP id v13mr3313692iob.189.1601507530756; Wed, 30 Sep 2020 16:12:10 -0700 (PDT) MIME-Version: 1.0 References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-7-bgardon@google.com> <20200930061047.GB29659@linux.intel.com> In-Reply-To: <20200930061047.GB29659@linux.intel.com> From: Ben Gardon Date: Wed, 30 Sep 2020 16:11:59 -0700 Message-ID: Subject: Re: [PATCH 06/22] kvm: mmu: Make address space ID a property of memslots To: Sean Christopherson Cc: LKML , kvm , Cannon Matthews , Paolo Bonzini , Peter Xu , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 29, 2020 at 11:11 PM Sean Christopherson wrote: > > On Fri, Sep 25, 2020 at 02:22:46PM -0700, Ben Gardon wrote: > > Save address space ID as a field in each memslot so that functions that > > do not use rmaps (which implicitly encode the id) can handle multiple > > address spaces correctly. > > > > Tested by running kvm-unit-tests and KVM selftests on an Intel Haswell > > machine. This series introduced no new failures. > > > > This series can be viewed in Gerrit at: > > https://linux-review.googlesource.com/c/virt/kvm/kvm/+/2538 > > > > Signed-off-by: Ben Gardon > > --- > > include/linux/kvm_host.h | 1 + > > virt/kvm/kvm_main.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 05e3c2fb3ef78..a460bc712a81c 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -345,6 +345,7 @@ struct kvm_memory_slot { > > struct kvm_arch_memory_slot arch; > > unsigned long userspace_addr; > > u32 flags; > > + int as_id; > > Ha! Peter Xu's dirtly ring also added this. This should be a u16, it'll > save 8 bytes per memslot (oooooooh). Any chance you want to include Peter's > patch[*]? It has some nitpicking from Peter and I regarding what to do > with as_id on deletion. That would also avoid silent merge conflicts on > Peter's end. > > [*] https://lkml.kernel.org/r/20200708193408.242909-2-peterx@redhat.com Oh that's great! Yes, let's use Peter's patch in place of this one. > > > short id; > > }; > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index cf88233b819a0..f9c80351c9efd 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -1318,6 +1318,7 @@ int __kvm_set_memory_region(struct kvm *kvm, > > new.npages = mem->memory_size >> PAGE_SHIFT; > > new.flags = mem->flags; > > new.userspace_addr = mem->userspace_addr; > > + new.as_id = as_id; > > > > if (new.npages > KVM_MEM_MAX_NR_PAGES) > > return -EINVAL; > > -- > > 2.28.0.709.gb0816b6eb0-goog > >