From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: kvm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 01/10] driver core: Do not continue searching for drivers if deferred probe is used
Date: Tue, 8 Jun 2021 09:35:17 +0200 [thread overview]
Message-ID: <YL8dtaVoNGFo9PwU@kroah.com> (raw)
In-Reply-To: <1-v1-324b2038f212+1041f1-vfio3a_jgg@nvidia.com>
On Mon, Jun 07, 2021 at 09:55:43PM -0300, Jason Gunthorpe wrote:
> Once a driver has been matched and probe() returns with -EPROBE_DEFER the
> device is added to a deferred list and will be retried later.
>
> At this point __device_attach_driver() should stop trying other drivers as
> we have "matched" this driver and already scheduled another probe to
> happen later.
>
> Return the -EPROBE_DEFER from really_probe() instead of squashing it to
> zero. This is similar to the code at the top of the function which
> directly returns -EPROBE_DEFER.
>
> It is not really a bug as, AFAIK, we don't actually have cases where
> multiple drivers can bind.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/base/dd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index ecd7cf848daff7..9d79a139290271 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -656,7 +656,7 @@ static int really_probe(struct device *dev, struct device_driver *drv)
> /* Driver requested deferred probing */
> dev_dbg(dev, "Driver %s requests probe deferral\n", drv->name);
> driver_deferred_probe_add_trigger(dev, local_trigger_count);
> - break;
> + goto done;
> case -ENODEV:
> case -ENXIO:
> pr_debug("%s: probe of %s rejects match %d\n",
> --
> 2.31.1
>
Why is lkml not cc:ed on driver core changes like get_maintainer.pl will
say?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-08 7:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 0:55 [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 01/10] driver core: Do not continue searching for drivers if deferred probe is used Jason Gunthorpe
2021-06-08 5:51 ` Christoph Hellwig
2021-06-08 6:44 ` Greg Kroah-Hartman
2021-06-08 12:16 ` Jason Gunthorpe
2021-06-08 13:13 ` Greg Kroah-Hartman
2021-06-08 13:53 ` Jason Gunthorpe
2021-06-08 7:35 ` Greg Kroah-Hartman [this message]
2021-06-08 12:17 ` Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 02/10] driver core: Pull required checks into driver_probe_device() Jason Gunthorpe
2021-06-08 5:59 ` Christoph Hellwig
2021-06-08 12:21 ` Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Jason Gunthorpe
2021-06-08 6:07 ` Christoph Hellwig
2021-06-08 23:53 ` Jason Gunthorpe
2021-06-08 6:47 ` Greg Kroah-Hartman
2021-06-08 12:30 ` Jason Gunthorpe
2021-06-08 13:16 ` Greg Kroah-Hartman
2021-06-08 14:03 ` Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Jason Gunthorpe
2021-06-08 6:14 ` Christoph Hellwig
2021-06-08 7:37 ` Greg Kroah-Hartman
2021-06-08 0:55 ` [PATCH 05/10] driver core: Export device_driver_attach() Jason Gunthorpe
2021-06-08 6:19 ` Christoph Hellwig
2021-06-08 12:33 ` Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Jason Gunthorpe
2021-06-08 6:20 ` Christoph Hellwig
2021-06-11 12:40 ` Cornelia Huck
2021-06-14 12:35 ` Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Jason Gunthorpe
2021-06-08 6:21 ` Christoph Hellwig
2021-06-08 0:55 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 09/10] vfio/mdpy: " Jason Gunthorpe
2021-06-08 0:55 ` [PATCH 10/10] vfio/mbochs: " Jason Gunthorpe
2021-06-08 6:22 ` [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Christoph Hellwig
2021-06-14 14:34 ` Kirti Wankhede
2021-06-14 14:36 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL8dtaVoNGFo9PwU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).