From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D097C43460 for ; Tue, 11 May 2021 08:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAE0961624 for ; Tue, 11 May 2021 08:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhEKIkD (ORCPT ); Tue, 11 May 2021 04:40:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53094 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbhEKIkB (ORCPT ); Tue, 11 May 2021 04:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620722335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oAopTEbdD9SUh6PQTXI2MykT2T2jIRp0VGhtGVWodjg=; b=I9C6OlbcmXOMZOkN0/jLrZOqQ1B+Rf890chd7w6VaAKWOoI0nKTlHCPThla8IthEZMj6iz zNYnKvTpfrSjh6/22ZHLmF2RiHJhn1BfxxjIrSXRuczEcDjQRfPbToETKhFVxpsZZeKhGK Qo33zxiA30ezsYMg6ffxUj9vYPfG2pk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-ZqyjPjiJNe2uKwGpOH9Org-1; Tue, 11 May 2021 04:38:53 -0400 X-MC-Unique: ZqyjPjiJNe2uKwGpOH9Org-1 Received: by mail-ej1-f72.google.com with SMTP id c11-20020a170906170bb02903bbefa04cd1so1943319eje.8 for ; Tue, 11 May 2021 01:38:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oAopTEbdD9SUh6PQTXI2MykT2T2jIRp0VGhtGVWodjg=; b=J4sFY9sEvqx6OSDCAaYmLo6jRuQofBIOa1UrSy1RwGk8Z2Qe+X0pVN48CSfU9POUCY wGJIZcpfXIks9qk9IWcsY9wAUFNmFNAjtNKobcm6Xi5vlnkWB4DUQvNiAEojWCoqhlQy evUSjfDVDtlix+EnzRMeDwE2a73o9N4Ysdt3uDdGt9BdUa/T3TSFljlMsuNTZrqRjYQ/ 0K2hn5aQYK7LQ0/oqcA8MKWsED44w84puqRDngZQAsk/nXww9EcOn29M84nLGiDP6FeN RINi5lTUI+atD3r9+YhPhfAgXT3f5oy7NZqFHfx/ujJHI5bTnS3fr81p47gBNAVBnfTH WjMA== X-Gm-Message-State: AOAM530h9AlgUK51FuKKDRwRM9lFV5ciQ4sg9SgB8ACrrs4jR/TfTrhm K0jogfoydHog5Qq9mqF3X+5nZmqwb9YOWscWn1/gVhCCfo0cbAMgUyHQ8emnMxDF1Jc0kl1ny5u 9iZIeRw60Wnup X-Received: by 2002:a17:906:9718:: with SMTP id k24mr1941008ejx.23.1620722332728; Tue, 11 May 2021 01:38:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT75fua4+WgIi/rgmXTzVvo4K8REfXZdDbFxcG2kK4Dqn2ZsdkeL1pgt+qT2yOLrXO7W/tLA== X-Received: by 2002:a17:906:9718:: with SMTP id k24mr1940987ejx.23.1620722332520; Tue, 11 May 2021 01:38:52 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b21sm11083756ejg.80.2021.05.11.01.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 01:38:51 -0700 (PDT) Subject: Re: [PATCH v4 0/4] KVM statistics data fd-based binary interface To: Jing Zhang , KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito References: <20210429203740.1935629-1-jingzhangos@google.com> From: Paolo Bonzini Message-ID: Date: Tue, 11 May 2021 10:38:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/05/21 20:57, Jing Zhang wrote: > Hi Paolo, > > On Thu, Apr 29, 2021 at 3:37 PM Jing Zhang wrote: >> >> This patchset provides a file descriptor for every VM and VCPU to read >> KVM statistics data in binary format. >> It is meant to provide a lightweight, flexible, scalable and efficient >> lock-free solution for user space telemetry applications to pull the >> statistics data periodically for large scale systems. The pulling >> frequency could be as high as a few times per second. >> In this patchset, every statistics data are treated to have some >> attributes as below: >> * architecture dependent or common >> * VM statistics data or VCPU statistics data >> * type: cumulative, instantaneous, >> * unit: none for simple counter, nanosecond, microsecond, >> millisecond, second, Byte, KiByte, MiByte, GiByte. Clock Cycles >> Since no lock/synchronization is used, the consistency between all >> the statistics data is not guaranteed. That means not all statistics >> data are read out at the exact same time, since the statistics date >> are still being updated by KVM subsystems while they are read out. >> >> --- >> >> * v3 -> v4 >> - Rebase to kvm/queue, commit 9f242010c3b4 ("KVM: avoid "deadlock" >> between install_new_memslots and MMU notifier") >> - Use C-stype comments in the whole patch >> - Fix wrong count for x86 VCPU stats descriptors >> - Fix KVM stats data size counting and validity check in selftest >> >> * v2 -> v3 >> - Rebase to kvm/queue, commit edf408f5257b ("KVM: avoid "deadlock" >> between install_new_memslots and MMU notifier") >> - Resolve some nitpicks about format >> >> * v1 -> v2 >> - Use ARRAY_SIZE to count the number of stats descriptors >> - Fix missing `size` field initialization in macro STATS_DESC >> >> [1] https://lore.kernel.org/kvm/20210402224359.2297157-1-jingzhangos@google.com >> [2] https://lore.kernel.org/kvm/20210415151741.1607806-1-jingzhangos@google.com >> [3] https://lore.kernel.org/kvm/20210423181727.596466-1-jingzhangos@google.com >> >> --- >> >> Jing Zhang (4): >> KVM: stats: Separate common stats from architecture specific ones >> KVM: stats: Add fd-based API to read binary stats data >> KVM: stats: Add documentation for statistics data binary interface >> KVM: selftests: Add selftest for KVM statistics data binary interface >> >> Documentation/virt/kvm/api.rst | 171 ++++++++ >> arch/arm64/include/asm/kvm_host.h | 9 +- >> arch/arm64/kvm/guest.c | 42 +- >> arch/mips/include/asm/kvm_host.h | 9 +- >> arch/mips/kvm/mips.c | 67 ++- >> arch/powerpc/include/asm/kvm_host.h | 9 +- >> arch/powerpc/kvm/book3s.c | 68 +++- >> arch/powerpc/kvm/book3s_hv.c | 12 +- >> arch/powerpc/kvm/book3s_pr.c | 2 +- >> arch/powerpc/kvm/book3s_pr_papr.c | 2 +- >> arch/powerpc/kvm/booke.c | 63 ++- >> arch/s390/include/asm/kvm_host.h | 9 +- >> arch/s390/kvm/kvm-s390.c | 133 +++++- >> arch/x86/include/asm/kvm_host.h | 9 +- >> arch/x86/kvm/x86.c | 71 +++- >> include/linux/kvm_host.h | 132 +++++- >> include/linux/kvm_types.h | 12 + >> include/uapi/linux/kvm.h | 50 +++ >> tools/testing/selftests/kvm/.gitignore | 1 + >> tools/testing/selftests/kvm/Makefile | 3 + >> .../testing/selftests/kvm/include/kvm_util.h | 3 + >> .../selftests/kvm/kvm_bin_form_stats.c | 380 ++++++++++++++++++ >> tools/testing/selftests/kvm/lib/kvm_util.c | 11 + >> virt/kvm/kvm_main.c | 237 ++++++++++- >> 24 files changed, 1415 insertions(+), 90 deletions(-) >> create mode 100644 tools/testing/selftests/kvm/kvm_bin_form_stats.c >> >> >> base-commit: 9f242010c3b46e63bc62f08fff42cef992d3801b >> -- >> 2.31.1.527.g47e6f16901-goog >> > > Do I need to send another version for this? No, the merge window has just finished and I wanted to flush the dozens of bugfix patches that I had. I'll get to it shortly. Paolo