From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg
Date: Fri, 7 Aug 2020 14:12:58 +0200 [thread overview]
Message-ID: <da95ddbb-0761-8319-3833-b5f506e87af7@redhat.com> (raw)
In-Reply-To: <20200807111555.11169-3-frankja@linux.ibm.com>
On 07/08/2020 13.15, Janosch Frank wrote:
> When an exception new psw with a storage key in its mask is loaded
> from lowcore, a specification exception is raised. This differs from
> the behavior when trying to execute skey related instructions, which
> will result in special operation exceptions.
>
> Also let's add the test to unittests.cfg so it is run more often.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/skrf.c | 79 +++++++++++++++++++++++++++++++++++++++++++++
> s390x/unittests.cfg | 4 +++
> 2 files changed, 83 insertions(+)
It's hot here today, so my review skills might have melted a little bit,
but as far as I can see, it looks fine now:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-08-07 12:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:15 [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 1/3] s390x: Add custom pgm cleanup function Janosch Frank
2020-08-10 12:21 ` Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg Janosch Frank
2020-08-07 12:12 ` Thomas Huth [this message]
2020-08-10 14:38 ` Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 3/3] s390x: Ultravisor guest API test Janosch Frank
2020-08-07 12:14 ` Thomas Huth
2020-08-10 14:50 ` Cornelia Huck
2020-08-10 15:27 ` Janosch Frank
2020-08-10 15:32 ` Cornelia Huck
2020-08-10 15:45 ` [kvm-unit-tests PATCH v3] " Janosch Frank
2020-08-10 15:50 ` Cornelia Huck
2020-08-11 7:18 ` Janosch Frank
2020-08-11 7:29 ` [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 9:54 Janosch Frank
2020-07-27 9:54 ` [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg Janosch Frank
2020-07-27 12:20 ` Thomas Huth
2020-07-27 12:38 ` Janosch Frank
2020-07-30 11:03 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da95ddbb-0761-8319-3833-b5f506e87af7@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).