kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	Sean Christopherson <seanjc@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait
Date: Sat, 13 Mar 2021 10:29:53 +0100	[thread overview]
Message-ID: <e363db67-598b-619a-f844-d68dfb1d041a@redhat.com> (raw)
In-Reply-To: <CANRm+Cy42tM1M2vkuZk3y_-_wD-re9QxvoxWPGmyew+k1j_67w@mail.gmail.com>

On 13/03/21 01:57, Wanpeng Li wrote:
>> A third option would be to split the paths.  In the end, it's only the ptr/val
>> line that's shared.
> I just sent out a formal patch for my alternative fix, I think the
> whole logic in kvm_wait is more clear w/ my version.
> 

I don't know, having three "if"s in 10 lines of code is a bit daunting.

Paolo


  reply	other threads:[~2021-03-13  9:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23  5:25 [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait Wanpeng Li
2021-02-23  5:28 ` Wanpeng Li
2021-03-11 15:54   ` Sean Christopherson
2021-03-11 18:09     ` Paolo Bonzini
2021-03-13  0:57     ` Wanpeng Li
2021-03-13  9:29       ` Paolo Bonzini [this message]
2021-03-15  6:56         ` Wanpeng Li
2021-03-11  3:09 ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e363db67-598b-619a-f844-d68dfb1d041a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).