From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
jgg@nvidia.com, cohuck@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.williamson@redhat.com
Cc: liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com,
leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com,
shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com,
ACurrid@nvidia.com, gmataev@nvidia.com, cjia@nvidia.com,
yishaih@nvidia.com, aik@ozlabs.ru
Subject: Re: [PATCH 5/9] vfio-pci/zdev: remove unused vdev argument
Date: Mon, 1 Feb 2021 12:27:16 -0500 [thread overview]
Message-ID: <ffb61cac-f3ab-a96c-30c6-09ef08907f4b@linux.ibm.com> (raw)
In-Reply-To: <20210201162828.5938-6-mgurtovoy@nvidia.com>
On 2/1/21 11:28 AM, Max Gurtovoy wrote:
> Zdev static functions does not use vdev argument. Remove it.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Huh. I must have dropped the use of vdev somewhere during review
versions. Thanks!
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
@Alex/@Connie This one is just a cleanup and could also go separately
from this set if it makes sense.
> ---
> drivers/vfio/pci/vfio_pci_zdev.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
> index 7b20b34b1034..175096fcd902 100644
> --- a/drivers/vfio/pci/vfio_pci_zdev.c
> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
> @@ -24,8 +24,7 @@
> /*
> * Add the Base PCI Function information to the device info region.
> */
> -static int zpci_base_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> - struct vfio_info_cap *caps)
> +static int zpci_base_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
> {
> struct vfio_device_info_cap_zpci_base cap = {
> .header.id = VFIO_DEVICE_INFO_CAP_ZPCI_BASE,
> @@ -45,8 +44,7 @@ static int zpci_base_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> /*
> * Add the Base PCI Function Group information to the device info region.
> */
> -static int zpci_group_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> - struct vfio_info_cap *caps)
> +static int zpci_group_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
> {
> struct vfio_device_info_cap_zpci_group cap = {
> .header.id = VFIO_DEVICE_INFO_CAP_ZPCI_GROUP,
> @@ -66,8 +64,7 @@ static int zpci_group_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> /*
> * Add the device utility string to the device info region.
> */
> -static int zpci_util_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> - struct vfio_info_cap *caps)
> +static int zpci_util_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
> {
> struct vfio_device_info_cap_zpci_util *cap;
> int cap_size = sizeof(*cap) + CLP_UTIL_STR_LEN;
> @@ -90,8 +87,7 @@ static int zpci_util_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> /*
> * Add the function path string to the device info region.
> */
> -static int zpci_pfip_cap(struct zpci_dev *zdev, struct vfio_pci_device *vdev,
> - struct vfio_info_cap *caps)
> +static int zpci_pfip_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
> {
> struct vfio_device_info_cap_zpci_pfip *cap;
> int cap_size = sizeof(*cap) + CLP_PFIP_NR_SEGMENTS;
> @@ -123,21 +119,21 @@ int vfio_pci_info_zdev_add_caps(struct vfio_pci_device *vdev,
> if (!zdev)
> return -ENODEV;
>
> - ret = zpci_base_cap(zdev, vdev, caps);
> + ret = zpci_base_cap(zdev, caps);
> if (ret)
> return ret;
>
> - ret = zpci_group_cap(zdev, vdev, caps);
> + ret = zpci_group_cap(zdev, caps);
> if (ret)
> return ret;
>
> if (zdev->util_str_avail) {
> - ret = zpci_util_cap(zdev, vdev, caps);
> + ret = zpci_util_cap(zdev, caps);
> if (ret)
> return ret;
> }
>
> - ret = zpci_pfip_cap(zdev, vdev, caps);
> + ret = zpci_pfip_cap(zdev, caps);
>
> return ret;
> }
>
next prev parent reply other threads:[~2021-02-01 17:28 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:28 [PATCH v2 0/9] Introduce vfio-pci-core subsystem Max Gurtovoy
2021-02-01 16:28 ` [PATCH 1/9] vfio-pci: rename vfio_pci.c to vfio_pci_core.c Max Gurtovoy
2021-02-01 16:28 ` [PATCH 2/9] vfio-pci: introduce vfio_pci_core subsystem driver Max Gurtovoy
2021-02-01 16:28 ` [PATCH 3/9] vfio-pci-core: export vfio_pci_register_dev_region function Max Gurtovoy
2021-02-01 16:28 ` [PATCH 4/9] mlx5-vfio-pci: add new vfio_pci driver for mlx5 devices Max Gurtovoy
2021-02-01 16:28 ` [PATCH 5/9] vfio-pci/zdev: remove unused vdev argument Max Gurtovoy
2021-02-01 17:27 ` Matthew Rosato [this message]
2021-02-02 7:57 ` Cornelia Huck
2021-02-02 17:21 ` Alex Williamson
2021-02-01 16:28 ` [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue Max Gurtovoy
2021-02-01 16:52 ` Cornelia Huck
2021-02-01 17:08 ` Matthew Rosato
2021-02-01 20:47 ` Alex Williamson
2021-02-02 7:58 ` Cornelia Huck
2021-02-01 16:28 ` [PATCH 7/9] vfio/pci: use s390 naming instead of zdev Max Gurtovoy
2021-02-01 16:28 ` [PATCH 8/9] vfio/pci: use x86 naming instead of igd Max Gurtovoy
2021-02-01 17:14 ` Cornelia Huck
2021-02-01 17:49 ` Matthew Rosato
2021-02-01 18:42 ` Alex Williamson
2021-02-02 16:06 ` Cornelia Huck
2021-02-02 17:10 ` Jason Gunthorpe
2021-02-11 15:47 ` Max Gurtovoy
2021-02-11 16:29 ` Matthew Rosato
2021-02-11 17:39 ` Cornelia Huck
2021-02-02 17:41 ` Max Gurtovoy
2021-02-02 17:54 ` Alex Williamson
2021-02-02 18:50 ` Jason Gunthorpe
2021-02-02 18:55 ` Christoph Hellwig
2021-02-02 19:05 ` Jason Gunthorpe
2021-02-02 19:37 ` Alex Williamson
2021-02-02 20:44 ` Jason Gunthorpe
2021-02-02 20:59 ` Max Gurtovoy
2021-02-02 21:30 ` Alex Williamson
2021-02-02 23:06 ` Jason Gunthorpe
2021-02-02 23:59 ` Alex Williamson
2021-02-03 13:54 ` Jason Gunthorpe
2021-02-11 8:47 ` Christoph Hellwig
2021-02-11 14:30 ` Jason Gunthorpe
2021-02-11 8:44 ` Christoph Hellwig
2021-02-11 19:43 ` Alex Williamson
[not found] ` <806c138e-685c-0955-7c15-93cb1d4fe0d9@ozlabs.ru>
2021-02-03 16:07 ` Max Gurtovoy
[not found] ` <83ef0164-6291-c3d1-0ce5-2c9d6c97469e@ozlabs.ru>
2021-02-04 12:51 ` Jason Gunthorpe
2021-02-05 0:42 ` Alexey Kardashevskiy
2021-02-08 12:44 ` Max Gurtovoy
2021-02-09 1:55 ` Alexey Kardashevskiy
2021-02-08 18:13 ` Jason Gunthorpe
2021-02-09 1:51 ` Alexey Kardashevskiy
2021-02-04 9:12 ` Max Gurtovoy
2021-02-11 8:50 ` Christoph Hellwig
2021-02-11 14:49 ` Jason Gunthorpe
2021-02-01 16:28 ` [PATCH 9/9] vfio/pci: use powernv naming instead of nvlink2 Max Gurtovoy
2021-02-01 18:35 ` Jason Gunthorpe
2021-02-10 7:52 ` [PATCH v2 0/9] Introduce vfio-pci-core subsystem Tian, Kevin
2021-02-10 13:34 ` Jason Gunthorpe
2021-02-10 16:37 ` Alex Williamson
2021-02-10 17:08 ` Jason Gunthorpe
2021-02-11 8:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb61cac-f3ab-a96c-30c6-09ef08907f4b@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=ACurrid@nvidia.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=artemp@nvidia.com \
--cc=aviadye@nvidia.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=gmataev@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liranl@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=tzahio@nvidia.com \
--cc=yarong@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).