From: Alexander Graf <graf@amazon.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Andre Przywara <andre.przywara@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests] arm: Add PL031 test
Date: Thu, 11 Jul 2019 07:49:45 +0200 [thread overview]
Message-ID: <1537a9f2-9d23-97dd-b195-8239b263d5db@amazon.com> (raw)
In-Reply-To: <35e19306-d31b-187b-185d-e783f8d5a51a@redhat.com>
On 10.07.19 19:06, Paolo Bonzini wrote:
> On 10/07/19 19:02, Andre Przywara wrote:
>>> + * This test verifies whether the emulated PL031 behaves
>>> correctly.
>> ^^^^^^^^
>>
>> While I appreciate the effort and like the fact that this actually
>> triggers an SPI, I wonder if this actually belongs into
>> kvm-unit-tests. After all this just test a device purely emulated in
>> (QEMU) userland, so it's not really KVM related.
>>
>> What is the general opinion on this? Don't we care about this
>> hair-splitting as long as it helps testing? Do we even want to extend
>> kvm-unit-tests coverage to more emulated devices, for instance
>> virtio?
>
> I agree that it would belong more in qtest, but tests in not exactly the
> right place is better than no tests.
The problem with qtest is that it tests QEMU device models from a QEMU
internal view.
I am much more interested in the guest visible side of things. If
kvmtool wanted to implement a PL031, it should be able to execute the
same test that we run against QEMU, no?
If kvm-unit-test is the wrong place for it, we would probably want to
have a separate testing framework for guest side unit tests targeting
emulated devices.
Given how nice the kvm-unit-test framework is though, I'd rather rename
it to "virt-unit-test" than reinvent the wheel :).
Alex
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-07-11 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 13:27 [PATCH kvm-unit-tests] arm: Add PL031 test Alexander Graf
2019-07-10 14:25 ` Marc Zyngier
2019-07-12 8:29 ` Alexander Graf
2019-07-12 8:51 ` Marc Zyngier
2019-07-10 14:37 ` Alexandru Elisei
2019-07-10 17:02 ` Andre Przywara
2019-07-10 17:06 ` Paolo Bonzini
2019-07-11 5:49 ` Alexander Graf [this message]
2019-07-11 7:52 ` Paolo Bonzini
2019-07-11 9:42 ` Andre Przywara
2019-07-11 9:52 ` Marc Zyngier
2019-07-11 9:59 ` Alexander Graf
2019-07-11 8:51 ` Peter Maydell
2019-07-11 9:11 ` Alexander Graf
2019-07-11 9:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537a9f2-9d23-97dd-b195-8239b263d5db@amazon.com \
--to=graf@amazon.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).