From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC85BC432C3 for ; Thu, 14 Nov 2019 15:21:57 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 67383206DC for ; Thu, 14 Nov 2019 15:21:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67383206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DE19E4AEB8; Thu, 14 Nov 2019 10:21:56 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zockz1d8OKkK; Thu, 14 Nov 2019 10:21:55 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A730B4AF4C; Thu, 14 Nov 2019 10:21:55 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7D06C4AF4C for ; Thu, 14 Nov 2019 10:21:54 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b4cY8ZxnXSJj for ; Thu, 14 Nov 2019 10:21:53 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5378E4AEB8 for ; Thu, 14 Nov 2019 10:21:53 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D614F328; Thu, 14 Nov 2019 07:21:52 -0800 (PST) Received: from [10.1.196.63] (e123195-lin.cambridge.arm.com [10.1.196.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE3D13F52E; Thu, 14 Nov 2019 07:21:51 -0800 (PST) Subject: Re: [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS To: Vladimir Murzin , Andre Przywara References: <20191108144240.204202-1-andre.przywara@arm.com> <20191108144240.204202-10-andre.przywara@arm.com> <2e14ccd4-89f4-aa90-cc58-bebf0e2eeede@arm.com> <7ca57a0c-3934-1778-e3f9-a3eee0658002@arm.com> <20191114141745.32d3b89c@donnerap.cambridge.arm.com> <90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com> From: Alexandru Elisei Message-ID: <187393bb-a32d-092d-d0ea-44c58a54d1de@arm.com> Date: Thu, 14 Nov 2019 15:21:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com> Content-Language: en-US Cc: kvm@vger.kernel.org, Marc Zyngier , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On 11/14/19 2:50 PM, Vladimir Murzin wrote: > On 11/14/19 2:17 PM, Andre Przywara wrote: >> On Thu, 14 Nov 2019 13:39:33 +0000 >> Vladimir Murzin wrote: >> >>> Hi, >>> >>> On 11/12/19 4:42 PM, Alexandru Elisei wrote: >>>> Are we not testing KVM? Why are we not treating a behaviour different than what >>>> KVM should emulate as a fail? >>> Can kvm-unit-tests be run with qemu TCG? >> Yes, it does that actually by default if you cross compile. I also tested this explicitly on TCG: unlike KVM that actually passes all those tests. >> If you set the environment variable ACCEL to either tcg or kvm, you can select this at runtime: >> $ ACCEL=tcg arm/run arm/gic.flat -smp 3 -append irq > Great! Then, IMO, it is absolutely valid to test this functionality! TCG emulates a GIC with a single security state for me: /usr/bin/qemu-system-aarch64 -nodefaults -machine virt,gic-version=3,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -append irq PASS: gicv3: irq: SPI triggered by CPU write PASS: gicv3: irq: disabled SPI does not fire PASS: gicv3: irq: now enabled SPI fires INFO: gicv3: irq: GROUP: GIC is one security state only [..] But that could change someday, so I'm fine with failing only if we are not allowed to have GICD_CTLR.DS=1, because that will prevent us from testing group 0 interrupts. Thanks, Alex > Thanks > Vladimir > >> Cheers, >> Andre >> _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm