From: Andre Przywara <andre.przywara@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Christoffer Dall <cdall@kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
Zhang Lei <zhang.lei@jp.fujitsu.com>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error
Date: Fri, 31 May 2019 18:03:10 +0100 [thread overview]
Message-ID: <20190531180310.2305008c@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <1559229194-3036-3-git-send-email-Dave.Martin@arm.com>
On Thu, 30 May 2019 16:13:07 +0100
Dave Martin <Dave.Martin@arm.com> wrote:
> If in intermediate step fails, update_headers.sh blindly continues
> and may return success status.
>
> To avoid errors going unnoticed when driving this script, exit and
> report failure status as soon as something goes wrong. For good
> measure, also fail on expansion of undefined shell variables to aid
> future maintainers.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Both "u" and "e" seem to be standard and work in dash and ash, so:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Thanks,
Andre.
> ---
> util/update_headers.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/update_headers.sh b/util/update_headers.sh
> index 4ba1b9f..a7e21b8 100755
> --- a/util/update_headers.sh
> +++ b/util/update_headers.sh
> @@ -7,6 +7,8 @@
> # using the lib/modules/`uname -r`/source link.
> ########################################################################
>
> +set -ue
> +
> if [ "$#" -ge 1 ]
> then
> LINUX_ROOT="$1"
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-05-31 17:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:13 [PATCH kvmtool v3 0/9] arm64: Pointer Authentication and SVE support Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 1/9] update_headers.sh: Add missing shell quoting Dave Martin
2019-05-31 17:02 ` Andre Przywara
2019-06-03 10:40 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error Dave Martin
2019-05-31 17:03 ` Andre Przywara [this message]
2019-06-03 10:41 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 3/9] update_headers.sh: arm64: Copy sve_context.h if available Dave Martin
2019-05-31 17:03 ` Andre Przywara
2019-06-03 11:08 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 4/9] update_headers: Sync kvm UAPI headers with linux v5.1-rc1 Dave Martin
2019-05-31 17:03 ` Andre Przywara
2019-06-03 11:10 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 5/9] KVM: arm/arm64: Add a vcpu feature for pointer authentication Dave Martin
2019-05-31 17:04 ` Andre Przywara
2019-06-03 11:23 ` Dave Martin
2019-06-03 14:03 ` Andre Przywara
2019-06-03 14:18 ` Dave Martin
2019-06-03 14:07 ` Will Deacon
2019-06-03 14:17 ` Dave Martin
2019-06-03 13:48 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 6/9] arm/arm64: Factor out ptrauth vcpu feature setup Dave Martin
2019-05-31 17:04 ` Andre Przywara
2019-06-03 11:12 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 7/9] arm64: Make ptrauth enable/disable diagnostics more user-friendly Dave Martin
2019-05-31 17:05 ` Andre Przywara
2019-06-03 11:14 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 8/9] arm64: Add SVE support Dave Martin
2019-05-31 17:13 ` Andre Przywara
2019-06-03 11:15 ` Dave Martin
2019-05-30 15:13 ` [PATCH kvmtool v3 9/9] arm64: Select SVE vector lengths via the command line Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531180310.2305008c@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=Dave.Martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=cdall@kernel.org \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).