From: Andrew Jones <drjones@redhat.com>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 1/2] target/arm: kvm: Inject events at the last stage of sync
Date: Fri, 7 Feb 2020 08:41:20 +0100 [thread overview]
Message-ID: <20200207074120.emuqo4syqubpay4k@kamzik.brq.redhat.com> (raw)
In-Reply-To: <CADSWDzuQvZThaoFbeYM2QrDbwRPrZuiyDrVJV=jxiSMTW9O-rg@mail.gmail.com>
On Thu, Feb 06, 2020 at 09:41:10PM +0000, Beata Michalska wrote:
> On Tue, 4 Feb 2020 at 10:34, Andrew Jones <drjones@redhat.com> wrote:
> >
> > On Wed, Jan 29, 2020 at 08:24:40PM +0000, Beata Michalska wrote:
> > > KVM_SET_VCPU_EVENTS might actually lead to vcpu registers being modified.
> > > As such this should be the last step of sync to avoid potential overwriting
> > > of whatever changes KVM might have done.
> > >
> > > Signed-off-by: Beata Michalska <beata.michalska@linaro.org>
> > > ---
> > > target/arm/kvm32.c | 20 ++++++++++----------
> > > target/arm/kvm64.c | 20 ++++++++++----------
> > > 2 files changed, 20 insertions(+), 20 deletions(-)
> > >
> > > diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c
> > > index 32bf8d6..cf2b47f 100644
> > > --- a/target/arm/kvm32.c
> > > +++ b/target/arm/kvm32.c
> > > @@ -386,17 +386,17 @@ int kvm_arch_put_registers(CPUState *cs, int level)
> > > return ret;
> > > }
> > >
> > > - ret = kvm_put_vcpu_events(cpu);
> > > - if (ret) {
> > > - return ret;
> > > - }
> > > -
> > > write_cpustate_to_list(cpu, true);
> > >
> > > if (!write_list_to_kvmstate(cpu, level)) {
> > > return EINVAL;
> > > }
> > >
> > > + ret = kvm_put_vcpu_events(cpu);
> > > + if (ret) {
> > > + return ret;
> > > + }
> > > +
> >
> > I think we should put a comment above this that says basically the same
> > thing as the commit message in order to explain why kvm_put_vcpu_events()
> > *must* be after write_list_to_kvmstate().
> >
> Will do that.
>
> > > kvm_arm_sync_mpstate_to_kvm(cpu);
> > >
> > > return ret;
> > > @@ -462,11 +462,6 @@ int kvm_arch_get_registers(CPUState *cs)
> > > }
> > > vfp_set_fpscr(env, fpscr);
> > >
> > > - ret = kvm_get_vcpu_events(cpu);
> > > - if (ret) {
> > > - return ret;
> > > - }
> > > -
> > > if (!write_kvmstate_to_list(cpu)) {
> > > return EINVAL;
> > > }
> > > @@ -475,6 +470,11 @@ int kvm_arch_get_registers(CPUState *cs)
> > > */
> > > write_list_to_cpustate(cpu);
> > >
> > > + ret = kvm_get_vcpu_events(cpu);
> > > + if (ret) {
> > > + return ret;
> > > + }
> > > +
> >
> > Why are we moving kvm_get_vcpu_events()?
>
> This is only to make things consistent with put_registeres.
> There is no functional change per se.
Without a functional change I wouldn't move it. It's much
more appealing to have the final state writes at the bottom
of this function.
Thanks,
drew
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-02-07 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:24 [PATCH v2 0/2] target/arm: kvm: Support for KVM DABT without valid ISS Beata Michalska
2020-01-29 20:24 ` [PATCH v2 1/2] target/arm: kvm: Inject events at the last stage of sync Beata Michalska
2020-02-04 10:34 ` Andrew Jones
2020-02-06 21:41 ` Beata Michalska
2020-02-07 7:41 ` Andrew Jones [this message]
2020-01-29 20:24 ` [PATCH v2 2/2] target/arm: kvm: Handle DABT with no valid ISS Beata Michalska
2020-02-05 16:57 ` Andrew Jones
2020-02-06 21:48 ` Beata Michalska
2020-02-07 8:19 ` Andrew Jones
2020-02-11 23:10 ` Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207074120.emuqo4syqubpay4k@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).