From: Beata Michalska <beata.michalska@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu
Subject: [PATCH v7 0/2] target/arm: kvm: Support for KVM DABT with no valid ISS
Date: Sat, 27 Jun 2020 16:25:54 +0100 [thread overview]
Message-ID: <20200627152556.7391-1-beata.michalska@linaro.org> (raw)
Some of the ARMv7 & ARMv8 load/store instructions might trigger a data abort
exception with no valid ISS info to be decoded. The lack of decode info
makes it at least tricky to emulate the instruction which is one of the
(many) reasons why KVM will not even try to do so.
So far, if a guest made an attempt to access memory outside the memory slot,
KVM reported vague ENOSYS. As a result QEMU exited with no useful information
being provided or even a clue on what has just happened.
ARM KVM introduced support for notifying of an attempt to execute
an instruction that resulted in dabt with no valid ISS decoding info.
This still leaves QEMU to handle the case, but at least now it gives more
control and a start point for more meaningful handling of such cases.
This patchset relies on KVM to insert the external data abort into the guest.
----------------------
v7:
- Rephrasing the comment regarding abort injection and vcpu synchronization
- switching to struct initialization instead of memset
v6:
- replacing calling kvm_put_vcpu_events with an actual ioctl call
- making the handler function static
v5:
- Drop syncing vcpu regs in favour of calling kvm_put_vcpu_events directly
- Fix decoding DFSC for LPAE case
- Add/clarify comments
- Switch to reporting error case failure when enabling the cap
v4:
- Removing one of the patches as it is being picked-up separately
target/arm: kvm: Inject events at the last stage of sync
- Moving handling KVM issue to a separate patch
- Minor changes wrt the review comments
v3:
- Fix setting KVM cap per vm not per vcpu
- Simplifying the handler to bare minimum with no default logging to address
the potential risk of overflooding the host (adding support for rate
limiting the logs turned out to be bit too invasive to justify the little
add-on value from logs in this particular case)
- Adding handling KVM bug (for small range of affected kernels):
little bit of trade-off between what's reasonable and what's effective:
aborting qemu when running on buggy host kernel
v2:
- Improving/re-phrasing messaging
- Dropping messing around with forced sync (@see [PATCH v2 1/2])
and PC alignment
Beata Michalska (2):
target/arm: kvm: Handle DABT with no valid ISS
target/arm: kvm: Handle misconfigured dabt injection
target/arm/cpu.h | 2 ++
target/arm/kvm.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++-
target/arm/kvm32.c | 34 +++++++++++++++++++++
target/arm/kvm64.c | 49 ++++++++++++++++++++++++++++++
target/arm/kvm_arm.h | 10 ++++++
5 files changed, 180 insertions(+), 1 deletion(-)
--
2.7.4
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply other threads:[~2020-06-27 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 15:25 Beata Michalska [this message]
2020-06-27 15:25 ` [PATCH v7 1/2] target/arm: kvm: Handle DABT with no valid ISS Beata Michalska
2020-06-27 15:25 ` [PATCH v7 2/2] target/arm: kvm: Handle misconfigured dabt injection Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627152556.7391-1-beata.michalska@linaro.org \
--to=beata.michalska@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).