From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Zenghui Yu <yuzenghui@huawei.com>,
drjones@redhat.com, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH 2/3] arm64: timer: Use the proper RDist register name in GICv3
Date: Tue, 11 Feb 2020 09:26:16 +0000 [thread overview]
Message-ID: <50dcce90-b2b6-e375-b8af-9c1c53d43a4a@arm.com> (raw)
In-Reply-To: <20200211083901.1478-3-yuzenghui@huawei.com>
Hi,
On 2/11/20 8:39 AM, Zenghui Yu wrote:
> We're actually going to read GICR_ISACTIVER0 and GICR_ISPENDR0 (in
> SGI_base frame of the redistribitor) to get the active/pending state
> of the timer interrupt. Fix this typo.
>
> And since they have the same value, there's no functional change.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> arm/timer.c | 4 ++--
> lib/arm/asm/gic-v3.h | 4 ++++
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arm/timer.c b/arm/timer.c
> index 94543f2..10a88f3 100644
> --- a/arm/timer.c
> +++ b/arm/timer.c
> @@ -351,8 +351,8 @@ static void test_init(void)
> gic_icenabler = gicv2_dist_base() + GICD_ICENABLER;
> break;
> case 3:
> - gic_isactiver = gicv3_sgi_base() + GICD_ISACTIVER;
> - gic_ispendr = gicv3_sgi_base() + GICD_ISPENDR;
> + gic_isactiver = gicv3_sgi_base() + GICR_ISACTIVER0;
> + gic_ispendr = gicv3_sgi_base() + GICR_ISPENDR0;
> gic_isenabler = gicv3_sgi_base() + GICR_ISENABLER0;
> gic_icenabler = gicv3_sgi_base() + GICR_ICENABLER0;
> break;
> diff --git a/lib/arm/asm/gic-v3.h b/lib/arm/asm/gic-v3.h
> index 0dc838b..e2736a1 100644
> --- a/lib/arm/asm/gic-v3.h
> +++ b/lib/arm/asm/gic-v3.h
> @@ -32,6 +32,10 @@
> #define GICR_IGROUPR0 GICD_IGROUPR
> #define GICR_ISENABLER0 GICD_ISENABLER
> #define GICR_ICENABLER0 GICD_ICENABLER
> +#define GICR_ISPENDR0 GICD_ISPENDR
> +#define GICR_ICPENDR0 GICD_ICPENDR
> +#define GICR_ISACTIVER0 GICD_ISACTIVER
> +#define GICR_ICACTIVER0 GICD_ICACTIVER
> #define GICR_IPRIORITYR0 GICD_IPRIORITYR
>
> #define ICC_SGI1R_AFFINITY_1_SHIFT 16
Looks like an improvement to me:
Reviewed-by: Alexandru Elisei <alexandru.elisei@arm.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-02-11 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 8:38 [kvm-unit-tests PATCH 0/3] arm64: minor cleanups for timer test Zenghui Yu
2020-02-11 8:38 ` [kvm-unit-tests PATCH 1/3] arm/arm64: gic: Move gic_state enumeration to asm/gic.h Zenghui Yu
2020-02-11 8:39 ` [kvm-unit-tests PATCH 2/3] arm64: timer: Use the proper RDist register name in GICv3 Zenghui Yu
2020-02-11 9:26 ` Alexandru Elisei [this message]
2020-02-11 8:39 ` [kvm-unit-tests PATCH 3/3] arm64: timer: Use existing helpers to access counter/timers Zenghui Yu
2020-02-11 12:27 ` [kvm-unit-tests PATCH 0/3] arm64: minor cleanups for timer test Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50dcce90-b2b6-e375-b8af-9c1c53d43a4a@arm.com \
--to=alexandru.elisei@arm.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).