From: Marc Zyngier <marc.zyngier@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Julien Grall <julien.grall@arm.com>
Cc: ard.biesheuvel@linaro.org, Dave.Martin@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/3] arch/arm64: fpsimd: Introduce fpsimd_save_and_flush_cpu_state() and use it
Date: Tue, 4 Jun 2019 12:52:27 +0100 [thread overview]
Message-ID: <f5d4c8d2-9958-8257-8268-6b61ca485d60@arm.com> (raw)
In-Reply-To: <20190604111230.GA5668@arrakis.emea.arm.com>
On 04/06/2019 12:12, Catalin Marinas wrote:
> On Tue, May 21, 2019 at 06:21:38PM +0100, Julien Grall wrote:
>> The only external user of fpsimd_save() and fpsimd_flush_cpu_state() is
>> the KVM FPSIMD code.
>>
>> A following patch will introduce a mechanism to acquire owernship of the
>> FPSIMD/SVE context for performing context management operations. Rather
>> than having to export the new helpers to get/put the context, we can just
>> introduce a new function to combine fpsimd_save() and
>> fpsimd_flush_cpu_state().
>>
>> This has also the advantage to remove any external call of fpsimd_save()
>> and fpsimd_flush_cpu_state(), so they can be turned static.
>>
>> Lastly, the new function can also be used in the PM notifier.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> [...]
>> ---
>> arch/arm64/include/asm/fpsimd.h | 4 +---
>> arch/arm64/kernel/fpsimd.c | 17 +++++++++++++----
>> arch/arm64/kvm/fpsimd.c | 4 +---
>> 3 files changed, 15 insertions(+), 10 deletions(-)
>
> Marc, since this touches KVM, can I get an ack on this patch? I plan to
> queue the series.
Sure. Please add my
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
to the whole series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-06-04 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 17:21 [PATCH v5 0/3] arm64/fpsimd: Don't disable softirq when touching FPSIMD/SVE state Julien Grall
2019-05-21 17:21 ` [PATCH v5 1/3] arm64/fpsimd: Remove the prototype for sve_flush_cpu_state() Julien Grall
2019-05-21 17:21 ` [PATCH v5 2/3] arch/arm64: fpsimd: Introduce fpsimd_save_and_flush_cpu_state() and use it Julien Grall
2019-06-04 11:12 ` Catalin Marinas
2019-06-04 11:52 ` Marc Zyngier [this message]
2019-05-21 17:21 ` [PATCH v5 3/3] arm64/fpsimd: Don't disable softirq when touching FPSIMD/SVE state Julien Grall
2019-06-03 16:25 ` Catalin Marinas
2019-06-03 21:21 ` Catalin Marinas
2019-06-04 10:35 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d4c8d2-9958-8257-8268-6b61ca485d60@arm.com \
--to=marc.zyngier@arm.com \
--cc=Dave.Martin@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=julien.grall@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).