From: James Morse <james.morse@arm.com>
To: Shiju Jose <shiju.jose@huawei.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"lenb@kernel.org" <lenb@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"zhangliguang@linux.alibaba.com" <zhangliguang@linux.alibaba.com>,
"Wangkefeng (OS Kernel Lab)" <wangkefeng.wang@huawei.com>,
"jroedel@suse.de" <jroedel@suse.de>,
Linuxarm <linuxarm@huawei.com>,
yangyicong <yangyicong@huawei.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
tanxiaofei <tanxiaofei@huawei.com>
Subject: Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records
Date: Fri, 31 Jul 2020 14:47:59 +0100 [thread overview]
Message-ID: <185f69dd-bfec-20ce-01d6-76947f553e45@arm.com> (raw)
In-Reply-To: <20200722125038.GZ3703480@smile.fi.intel.com>
Hi Shiju,
On 22/07/2020 13:50, Andy Shevchenko wrote:
> On Wed, Jul 22, 2020 at 12:34:23PM +0000, Shiju Jose wrote:
>>>> Co-developed-by: James Morse <james.morse@arm.com>
>>>
>>> Co-developed-by: is going _in conjunction with_ SoB tag which is missing
>>> here.
>> This tag was added as per instruction from Rafael.
>> I was told that I cannot add SoB tag for others unless specifically given.
>> Probably I will leave it with Rafael/James to help on this SoB tag
>> as Rafael was ok to merge this patch.
>
> I think it's a misunderstanding somewhere. According to [1]:
> "Since Co-developed-by: denotes authorship, every Co-developed-by: must be
> immediately followed by a Signed-off-by: of the associated co-author."
>
> It means either both or none.
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Sorry for this mess! My intention was to summarise my suggestion in the form of a patch,
I wasn't expecting you to pick it up. (and I didn't post it because there was ongoing
discussion on the second part)
I'll repost this with the Co-Developed-by stuff. You'll need to re-post it with the
series, you'll need to move your Signed-Off-By to be last when you do that.
Thanks,
James
next prev parent reply other threads:[~2020-07-31 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 10:39 [PATCH v13 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors Shiju Jose
2020-07-22 10:39 ` [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records Shiju Jose
2020-07-22 11:01 ` Andy Shevchenko
2020-07-22 12:34 ` Shiju Jose
2020-07-22 12:50 ` Andy Shevchenko
2020-07-31 13:47 ` James Morse [this message]
2020-07-31 14:07 ` Shiju Jose
2020-07-23 23:20 ` Bjorn Helgaas
2020-07-24 9:00 ` Shiju Jose
2020-07-24 12:53 ` Bjorn Helgaas
2020-07-24 13:32 ` Shiju Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=185f69dd-bfec-20ce-01d6-76947f553e45@arm.com \
--to=james.morse@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=helgaas@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=jroedel@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=tony.luck@intel.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yangyicong@huawei.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).