From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-gpio@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
rjw@rjwysocki.net, jarkko.nikula@linux.intel.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
Date: Wed, 29 May 2019 12:13:42 +0200 [thread overview]
Message-ID: <20190529101342.30673-1-ard.biesheuvel@linaro.org> (raw)
The ACPI GPIO OpRegion code never sets the direction for GPIOs that
it configures from scratch, leaving unconfigured GPIOs to be left
at the default direction, which is typically input not output.
So set the direction and default value explicitly.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/gpio/gpiolib-acpi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index c9fc9e232aaf..02a2bc7fe18b 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -966,6 +966,12 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
goto out;
}
+ if (function == ACPI_WRITE)
+ gpiod_direction_output(desc,
+ !!((1 << i) & *value));
+ else
+ gpiod_direction_input(desc);
+
conn->pin = pin;
conn->desc = desc;
list_add_tail(&conn->node, &achip->conns);
--
2.20.1
next reply other threads:[~2019-05-29 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:13 Ard Biesheuvel [this message]
2019-05-29 10:27 ` [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs Mika Westerberg
2019-05-29 10:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529101342.30673-1-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).