From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14496C43218 for ; Tue, 11 Jun 2019 12:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE838214AF for ; Tue, 11 Jun 2019 12:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389187AbfFKMrF (ORCPT ); Tue, 11 Jun 2019 08:47:05 -0400 Received: from mga12.intel.com ([192.55.52.136]:63493 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387593AbfFKMrF (ORCPT ); Tue, 11 Jun 2019 08:47:05 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 05:47:04 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga008.fm.intel.com with ESMTP; 11 Jun 2019 05:47:02 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hagB3-0005CS-HY; Tue, 11 Jun 2019 15:47:01 +0300 Date: Tue, 11 Jun 2019 15:47:01 +0300 From: Andy Shevchenko To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH v4 2/7] i2c: acpi: Use available IRQ helper functions Message-ID: <20190611124701.GU9224@smile.fi.intel.com> References: <20190611123101.25264-1-ckeepax@opensource.cirrus.com> <20190611123101.25264-3-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611123101.25264-3-ckeepax@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jun 11, 2019 at 01:30:56PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. > > Reviewed-by: Mika Westerberg > Signed-off-by: Charles Keepax > --- > > No changes since v3. > > Apologies Andy but I really can't see a sensible way to split this > patch up. I have tried moving the resource_list_for_each_loop > into a function in one patch then switching to using > acpi_dev_resource_interrupt and i2c_dev_irq_from_resource, but the > function is basically a completely different function ie. all the > arguments are different and the purpose is different. So it makes > no sense, and it is very ping pong. I tried doing the switch to > i2c_dev_irq_from_resources as a separate patch which isn't so bad, > but feels pointless as it is such a small change, let me know if you > really want me to send that version. > > Basically the switch to the helper function and the use of > acpi_dev_resource_interrupt are intrinsically linked, so there isn't > really a sensible way to split those up. If you still want some > changes I am afraid you will have to be more specific in what you are > looking for. It seems I missed few details, thus the current approach works for me, thanks! > > Thanks, > Charles > > drivers/i2c/i2c-core-acpi.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c > index f1d648962b223..47d5b1c5ec9e0 100644 > --- a/drivers/i2c/i2c-core-acpi.c > +++ b/drivers/i2c/i2c-core-acpi.c > @@ -133,14 +133,25 @@ static int i2c_acpi_do_lookup(struct acpi_device *adev, > return 0; > } > > +static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data) > +{ > + int *irq = data; > + struct resource r; > + > + if (*irq <= 0 && acpi_dev_resource_interrupt(ares, 0, &r)) > + *irq = i2c_dev_irq_from_resources(&r, 1); > + > + return 1; /* No need to add resource to the list */ > +} > + > static int i2c_acpi_get_info(struct acpi_device *adev, > struct i2c_board_info *info, > struct i2c_adapter *adapter, > acpi_handle *adapter_handle) > { > struct list_head resource_list; > - struct resource_entry *entry; > struct i2c_acpi_lookup lookup; > + int irq = -ENOENT; > int ret; > > memset(&lookup, 0, sizeof(lookup)); > @@ -172,16 +183,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev, > > /* Then fill IRQ number if any */ > INIT_LIST_HEAD(&resource_list); > - ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > + ret = acpi_dev_get_resources(adev, &resource_list, > + i2c_acpi_add_resource, &irq); > if (ret < 0) > return -EINVAL; > > - resource_list_for_each_entry(entry, &resource_list) { > - if (resource_type(entry->res) == IORESOURCE_IRQ) { > - info->irq = entry->res->start; > - break; > - } > - } > + if (irq > 0) > + info->irq = irq; > > acpi_dev_free_resource_list(&resource_list); > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko