From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0A3C43331 for ; Fri, 6 Sep 2019 06:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6588B2084F for ; Fri, 6 Sep 2019 06:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404019AbfIFG7V (ORCPT ); Fri, 6 Sep 2019 02:59:21 -0400 Received: from mga04.intel.com ([192.55.52.120]:44127 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403977AbfIFG7V (ORCPT ); Fri, 6 Sep 2019 02:59:21 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 23:59:20 -0700 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="185704237" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 23:59:11 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 7014E2051A; Fri, 6 Sep 2019 09:59:07 +0300 (EEST) Date: Fri, 6 Sep 2019 09:59:07 +0300 From: Sakari Ailus To: Petr Mladek Cc: Andy Shevchenko , Steven Rostedt , Namhyung Kim , rafael@kernel.org, Rob Herring , Heikki Krogerus , Arnaldo Carvalho de Melo , Jiri Olsa , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Tzvetomir Stoyanov Subject: Re: [PATCH v4 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Message-ID: <20190906065907.GH5475@paasikivi.fi.intel.com> References: <20190902083240.20367-1-sakari.ailus@linux.intel.com> <20190902083240.20367-8-sakari.ailus@linux.intel.com> <20190902143935.xtd44jdvhjuc2wxe@pathway.suse.cz> <20190902160139.GQ2680@smile.fi.intel.com> <20190903140420.kmb42cwr3scrfd3e@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903140420.kmb42cwr3scrfd3e@pathway.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 03, 2019 at 04:04:20PM +0200, Petr Mladek wrote: > On Mon 2019-09-02 19:01:39, Andy Shevchenko wrote: > > On Mon, Sep 02, 2019 at 04:39:35PM +0200, Petr Mladek wrote: > > > On Mon 2019-09-02 11:32:36, Sakari Ailus wrote: > > > > %pS and %ps are now the preferred conversion specifiers to print function > > > > names. The functionality is equivalent; remove the old, deprecated %pF > > > > and %pf support. > > > > > > Hmm, I see the following in master: > > > > > > $> git grep %pF > > > tools/lib/traceevent/Documentation/libtraceevent-func_apis.txt:or events have "%pF" or "%pS" parameter in its format string. It is common to > > > > > > $> git grep %pf > > > tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0) > > > tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%s: %s", "%pf", printk->printk) < 0) > > > > > > I wonder how this is related to printk(). In each case, it seems > > > > It's going thru binary printf() I suppose. The fist stage just saves the format > > string and argument addresses or so and prints in later on when user is looking > > for human-readable output. > > It seems that vbin_printf() still thinks that %pf and %pF > handle function pointers. If I get it correctly, it just > stores the binary data and the formating is done when > tracing log is read. The idea is the function pointers > will stay the same. > > We need to fix/obsolete this path as well. Agreed. I'll include a patch to do that in v6. -- Sakari Ailus sakari.ailus@linux.intel.com