From: Andrew Lunn <andrew@lunn.ch>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Jon <jon@solid-run.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org,
linux.cj@gmail.com, "David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v2 1/3] net: phy: introduce find_phy_device()
Date: Wed, 1 Jul 2020 15:24:54 +0200 [thread overview]
Message-ID: <20200701132454.GF718441@lunn.ch> (raw)
In-Reply-To: <20200701061233.31120-2-calvin.johnson@oss.nxp.com>
> +struct phy_device *find_phy_device(struct fwnode_handle *fwnode)
We should consider the naming convention. All phylib phy functions
start with phy_. We already have phy_find_first(), so maybe
phy_find_by_fwnode() to follow the pattern?
> +{
> + struct fwnode_handle *fwnode_mdio;
> + struct platform_device *pdev;
> + struct mii_bus *mdio;
> + struct device *dev;
> + int addr;
> + int err;
> +
> + fwnode_mdio = fwnode_find_reference(fwnode, "mdio-handle", 0);
> + dev = bus_find_device_by_fwnode(&platform_bus_type, fwnode_mdio);
> + if (IS_ERR_OR_NULL(dev))
> + return NULL;
> + pdev = to_platform_device(dev);
> + mdio = platform_get_drvdata(pdev);
That is a big assumption to make. Please take a look at the
class_find_device_by_*() functions, as used by of_mdio_find_bus(),
mdio_find_bus(), etc.
Andrew
next prev parent reply other threads:[~2020-07-01 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 6:12 [net-next PATCH v2 0/3] ACPI support for dpaa2 MAC driver Calvin Johnson
2020-07-01 6:12 ` [net-next PATCH v2 1/3] net: phy: introduce find_phy_device() Calvin Johnson
2020-07-01 10:23 ` Andy Shevchenko
2020-07-01 13:24 ` Andrew Lunn [this message]
2020-07-01 6:12 ` [net-next PATCH v2 2/3] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-07-01 10:27 ` Andy Shevchenko
2020-07-03 11:35 ` Calvin Johnson
2020-07-04 11:40 ` Andy Shevchenko
2020-07-01 13:16 ` Randy Dunlap
2020-07-01 13:30 ` Andrew Lunn
2020-07-01 6:12 ` [net-next PATCH v2 3/3] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-07-01 10:37 ` Andy Shevchenko
2020-07-02 8:48 ` Ioana Ciornei
2020-07-02 9:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701132454.GF718441@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=kuba@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).