From: Bjorn Helgaas <helgaas@kernel.org>
To: Shiju Jose <shiju.jose@huawei.com>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rjw@rjwysocki.net, bp@alien8.de,
james.morse@arm.com, lenb@kernel.org, tony.luck@intel.com,
dan.carpenter@oracle.com, zhangliguang@linux.alibaba.com,
andriy.shevchenko@linux.intel.com, wangkefeng.wang@huawei.com,
jroedel@suse.de, linuxarm@huawei.com, yangyicong@hisilicon.com,
jonathan.cameron@huawei.com, tanxiaofei@huawei.com
Subject: Re: [PATCH v12 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records
Date: Tue, 14 Jul 2020 15:55:00 -0500 [thread overview]
Message-ID: <20200714205500.GA418237@bjorn-Precision-5520> (raw)
In-Reply-To: <20200713140901.853-2-shiju.jose@huawei.com>
On Mon, Jul 13, 2020 at 03:09:00PM +0100, Shiju Jose wrote:
> CPER records describing a firmware-first error are identified by GUID.
Does the spec really connect "firmware-first" and CPER records? Are
there non-firmware-first CPER records?
This sentence suggests that firmware-first CPER records are identified
by GUID, and that there are non-firmware-first CPER records that might
not be identified by GUID.
I suspect this would be better as simply:
CPER records are identified by a Notification Type GUID.
(Or maybe it's a Section Type GUID?)
> The ghes driver currently logs, but ignores any unknown CPER records.
> This prevents describing errors that can't be represented by a standard
> entry, that would otherwise allow a driver to recover from an error.
> The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of
> version 2.8).
>
> Add a notifier chain for these non-standard/vendor-records. Callers
> must identify their type of records by GUID.
>
> Record data is copied to memory from the ghes_estatus_pool to allow
> us to keep it until after the notifier has run.
prev parent reply other threads:[~2020-07-14 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:08 [PATCH v12 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors Shiju Jose
2020-07-13 14:09 ` [PATCH v12 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records Shiju Jose
2020-07-14 20:55 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714205500.GA418237@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=jroedel@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=tony.luck@intel.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).