From: kernel test robot <lkp@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, akpm@linux-foundation.org
Cc: kbuild-all@lists.01.org, Joao Martins <joao.m.martins@oracle.com>,
peterz@infradead.org, vishal.l.verma@intel.com,
dave.hansen@linux.intel.com, ard.biesheuvel@linaro.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 21/23] device-dax: Add an 'align' attribute
Date: Sat, 1 Aug 2020 14:18:12 +0800 [thread overview]
Message-ID: <202008011403.PtFkHpqE%lkp@intel.com> (raw)
In-Reply-To: <159625241660.3040297.3801913809845542130.stgit@dwillia2-desk3.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 6763 bytes --]
Hi Dan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url: https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base: 01830e6c042e8eb6eb202e05d7df8057135b4c26
config: arm-randconfig-r006-20200731 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/dax/bus.c: In function 'do_id_store':
drivers/dax/bus.c:94:27: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
94 | /* nothing to remove */;
| ^
drivers/dax/bus.c:99:29: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
99 | /* dax_id already added */;
| ^
In file included from include/linux/percpu-refcount.h:54,
from include/linux/memremap.h:6,
from drivers/dax/bus.c:3:
drivers/dax/bus.c: In function 'dev_dax_shrink':
include/linux/kernel.h:850:29: warning: comparison of distinct pointer types lacks a cast
850 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
include/linux/kernel.h:864:4: note: in expansion of macro '__typecheck'
864 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
include/linux/kernel.h:874:24: note: in expansion of macro '__safe_cmp'
874 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
include/linux/kernel.h:883:19: note: in expansion of macro '__careful_cmp'
883 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
drivers/dax/bus.c:881:12: note: in expansion of macro 'min'
881 | shrink = min(to_shrink, range_len(range));
| ^~~
In file included from include/linux/device.h:15,
from drivers/dax/bus.c:4:
drivers/dax/bus.c: In function 'dev_dax_validate_align':
drivers/dax/bus.c:1062:16: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/dax/bus.c:1062:3: note: in expansion of macro 'dev_dbg'
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ^~~~~~~
drivers/dax/bus.c:1062:50: note: format string is defined here
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ~~~^
| |
| long long unsigned int
| %u
In file included from include/linux/device.h:15,
from drivers/dax/bus.c:4:
drivers/dax/bus.c:1071:17: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'ssize_t' {aka 'int'} [-Wformat=]
1071 | dev_dbg(dev, "%s: align %u invalid for range %ld\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/dax/bus.c:1071:4: note: in expansion of macro 'dev_dbg'
1071 | dev_dbg(dev, "%s: align %u invalid for range %ld\n",
| ^~~~~~~
drivers/dax/bus.c:1071:51: note: format string is defined here
1071 | dev_dbg(dev, "%s: align %u invalid for range %ld\n",
| ~~^
| |
| long int
| %d
>> drivers/dax/bus.c:1082:7: error: 'PMD_SIZE' undeclared (first use in this function); did you mean 'PUD_SIZE'?
1082 | case PMD_SIZE:
| ^~~~~~~~
| PUD_SIZE
drivers/dax/bus.c:1082:7: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/compiler_types.h:65,
from <command-line>:
include/linux/compiler_attributes.h:214:41: warning: attribute 'fallthrough' not preceding a case label or default label
214 | # define fallthrough __attribute__((__fallthrough__))
| ^~~~~~~~~~~~~
drivers/dax/bus.c:1081:3: note: in expansion of macro 'fallthrough'
1081 | fallthrough;
| ^~~~~~~~~~~
vim +1082 drivers/dax/bus.c
1050
1051 static ssize_t dev_dax_validate_align(struct dev_dax *dev_dax)
1052 {
1053 resource_size_t dev_size = dev_dax_size(dev_dax);
1054 struct device *dev = &dev_dax->dev;
1055 ssize_t rc, i;
1056
1057 if (dev->driver)
1058 return -EBUSY;
1059
1060 rc = -EINVAL;
1061 if (dev_size > 0 && !alloc_is_aligned(dev_dax, dev_size)) {
1062 dev_dbg(dev, "%s: align %u invalid for size %llu\n",
1063 __func__, dev_dax->align, dev_size);
1064 return rc;
1065 }
1066
1067 for (i = 0; i < dev_dax->nr_range; i++) {
1068 size_t len = range_len(&dev_dax->ranges[i].range);
1069
1070 if (!alloc_is_aligned(dev_dax, len)) {
1071 dev_dbg(dev, "%s: align %u invalid for range %ld\n",
1072 __func__, dev_dax->align, i);
1073 return rc;
1074 }
1075 }
1076
1077 switch (dev_dax->align) {
1078 case PUD_SIZE:
1079 if (!IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD))
1080 break;
1081 fallthrough;
> 1082 case PMD_SIZE:
1083 if (!has_transparent_hugepage())
1084 break;
1085 fallthrough;
1086 case PAGE_SIZE:
1087 rc = 0;
1088 break;
1089 }
1090
1091 return rc;
1092 }
1093
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23508 bytes --]
next prev parent reply other threads:[~2020-08-01 6:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 3:24 [PATCH v3 00/23] device-dax: Support sub-dividing soft-reserved ranges Dan Williams
2020-08-01 3:25 ` [PATCH v3 01/23] x86/numa: Cleanup configuration dependent command-line options Dan Williams
2020-08-01 3:25 ` [PATCH v3 02/23] x86/numa: Add 'nohmat' option Dan Williams
2020-08-01 3:51 ` Randy Dunlap
2020-08-01 16:36 ` Dan Williams
2020-08-01 3:25 ` [PATCH v3 03/23] efi/fake_mem: Arrange for a resource entry per efi_fake_mem instance Dan Williams
2020-08-01 3:25 ` [PATCH v3 04/23] ACPI: HMAT: Refactor hmat_register_target_device to hmem_register_device Dan Williams
2020-08-01 3:25 ` [PATCH v3 05/23] resource: Report parent to walk_iomem_res_desc() callback Dan Williams
2020-08-01 3:25 ` [PATCH v3 06/23] mm/memory_hotplug: Introduce default phys_to_target_node() implementation Dan Williams
2020-08-01 3:25 ` [PATCH v3 07/23] ACPI: HMAT: Attach a device for each soft-reserved range Dan Williams
2020-08-01 3:25 ` [PATCH v3 08/23] device-dax: Drop the dax_region.pfn_flags attribute Dan Williams
2020-08-01 3:25 ` [PATCH v3 09/23] device-dax: Move instance creation parameters to 'struct dev_dax_data' Dan Williams
2020-08-01 3:25 ` [PATCH v3 10/23] device-dax: Make pgmap optional for instance creation Dan Williams
2020-08-01 3:26 ` [PATCH v3 11/23] device-dax: Kill dax_kmem_res Dan Williams
2020-08-01 3:26 ` [PATCH v3 12/23] device-dax: Add an allocation interface for device-dax instances Dan Williams
2020-08-01 3:26 ` [PATCH v3 13/23] device-dax: Introduce 'seed' devices Dan Williams
2020-08-01 3:26 ` [PATCH v3 14/23] drivers/base: Make device_find_child_by_name() compatible with sysfs inputs Dan Williams
2020-08-01 3:26 ` [PATCH v3 15/23] device-dax: Add resize support Dan Williams
2020-08-01 3:26 ` [PATCH v3 16/23] mm/memremap_pages: Convert to 'struct range' Dan Williams
2020-08-01 3:26 ` [PATCH v3 17/23] mm/memremap_pages: Support multiple ranges per invocation Dan Williams
2020-08-01 3:26 ` [PATCH v3 18/23] device-dax: Add dis-contiguous resource support Dan Williams
2020-08-01 3:26 ` [PATCH v3 19/23] device-dax: Introduce 'mapping' devices Dan Williams
2020-08-01 3:26 ` [PATCH v3 20/23] device-dax: Make align a per-device property Dan Williams
2020-08-01 7:23 ` kernel test robot
2020-08-01 3:26 ` [PATCH v3 21/23] device-dax: Add an 'align' attribute Dan Williams
2020-08-01 6:14 ` kernel test robot
2020-08-01 6:18 ` kernel test robot [this message]
2020-08-01 3:27 ` [PATCH v3 22/23] dax/hmem: Introduce dax_hmem.region_idle parameter Dan Williams
2020-08-01 3:27 ` [PATCH v3 23/23] device-dax: Add a range mapping allocation attribute Dan Williams
2020-08-04 17:02 ` [PATCH v3 00/23] device-dax: Support sub-dividing soft-reserved ranges Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008011403.PtFkHpqE%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=joao.m.martins@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=peterz@infradead.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).