From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Grant Likely <grant.likely@arm.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux.cj@gmail.com,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Diana Madalina Craciun <diana.craciun@nxp.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver
Date: Wed, 7 Oct 2020 21:20:11 +0530 [thread overview]
Message-ID: <20201007155011.GA27347@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <20201003173949.GB28093@lsv03152.swis.in-blr01.nxp.com>
On Sat, Oct 03, 2020 at 11:09:49PM +0530, Calvin Johnson wrote:
> Hi Grant,
>
> On Fri, Oct 02, 2020 at 12:22:37PM +0100, Grant Likely wrote:
> >
> >
<snip>
> > > -static int dpaa2_mac_get_if_mode(struct device_node *node,
> > > +static int dpaa2_mac_get_if_mode(struct fwnode_handle *dpmac_node,
> > > struct dpmac_attr attr)
> > > {
> > > phy_interface_t if_mode;
> > > int err;
> > > - err = of_get_phy_mode(node, &if_mode);
> > > - if (!err)
> > > - return if_mode;
> > > + err = fwnode_get_phy_mode(dpmac_node);
> > > + if (err > 0)
> > > + return err;
> >
> > Is this correct? The function prototype from patch 2 is:
> >
> > struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode)
> >
> > It returns struct fwnode_handle *. Does this compile?
>
> Will correct this.
Sorry, this change looks correct to me. Actully, the function prototype is:
int fwnode_get_phy_mode(struct fwnode_handle *fwnode);
It is from drivers/base/property.c.
fwnode_get_phy_node() defined in patch-2 is used in phylink_fwnode_phy_connect()
The confusion maybe due to one letter difference in the fn names.
Thanks
Calvin
next prev parent reply other threads:[~2020-10-07 15:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:04 [net-next PATCH v1 0/7] ACPI support for dpaa2 driver Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-09-30 16:37 ` Rafael J. Wysocki
2020-10-01 13:26 ` Calvin Johnson
2020-10-02 11:08 ` Grant Likely
2020-10-02 14:13 ` Rafael J. Wysocki
2020-09-30 16:04 ` [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions Calvin Johnson
2020-09-30 22:03 ` David Miller
2020-10-01 3:58 ` Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2020-09-30 16:34 ` Andrew Lunn
2020-09-30 18:07 ` Russell King - ARM Linux admin
2020-09-30 18:19 ` Andrew Lunn
2020-10-01 4:00 ` Calvin Johnson
2020-10-02 10:48 ` Grant Likely
2020-10-02 11:05 ` Grant Likely
2020-10-02 15:14 ` Florian Fainelli
2020-10-02 15:50 ` Russell King - ARM Linux admin
2020-10-03 18:03 ` Calvin Johnson
2020-10-03 18:00 ` Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 4/7] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2020-09-30 22:04 ` David Miller
2020-09-30 16:04 ` [net-next PATCH v1 5/7] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-10-01 15:36 ` Andy Shevchenko
2020-10-03 16:30 ` Calvin Johnson
2020-10-02 11:22 ` Grant Likely
2020-10-03 17:39 ` Calvin Johnson
2020-10-07 15:50 ` Calvin Johnson [this message]
2020-09-30 16:04 ` [net-next PATCH v1 7/7] net/fsl: Use _ADR ACPI object to register PHYs Calvin Johnson
2020-09-30 16:27 ` Andrew Lunn
2020-09-30 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007155011.GA27347@lsv03152.swis.in-blr01.nxp.com \
--to=calvin.johnson@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=grant.likely@arm.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).