From: Asmaa Mnebhi <asmaa@nvidia.com>
To: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Cc: Asmaa Mnebhi <asmaa@nvidia.com>,
andrew@lunn.ch, kuba@kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, davem@davemloft.net,
rjw@rjwysocki.net, davthompson@nvidia.com
Subject: [PATCH v3 0/2] gpio: mlxbf2: Introduce proper interrupt handling
Date: Thu, 23 Sep 2021 16:22:14 -0400 [thread overview]
Message-ID: <20210923202216.16091-1-asmaa@nvidia.com> (raw)
This is a follow up on a discussion regarding
proper handling of GPIO interrupts within the
gpio-mlxbf2.c driver.
Link to discussion:
https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@linux.intel.com/T/
Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c.
Patch 2 is a follow up removal of custom GPIO IRQ handling
from the mlxbf_gige driver and replacing it with a simple
IRQ request. The ACPI table for the mlxbf_gige driver is
responsible for instantiating the PHY GPIO interrupt via
GpioInt.
Andy Shevchenko, could you please review this patch series.
v3 vs. v2 patch:
- Add IRQ_TYPE_LEVEL* back to mlxbf2_gpio_irq_set_type.
YU_GPIO_CAUSE_FALL_EN and YU_GPIO_CAUSE_RISE_EN
are configured in Both level and edge interrupts cases.
Asmaa Mnebhi (2):
gpio: mlxbf2: Introduce IRQ support
net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
drivers/gpio/gpio-mlxbf2.c | 150 ++++++++++++-
.../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 -
.../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 -
.../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------
.../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +-
5 files changed, 157 insertions(+), 240 deletions(-)
delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
--
2.30.1
next reply other threads:[~2021-09-23 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 20:22 Asmaa Mnebhi [this message]
2021-09-23 20:22 ` [PATCH v3 1/2] gpio: mlxbf2: Introduce IRQ support Asmaa Mnebhi
2021-09-24 11:46 ` Andrew Lunn
2021-09-24 23:48 ` Linus Walleij
2021-09-27 14:04 ` Asmaa Mnebhi
2021-09-27 14:08 ` Andrew Lunn
2021-09-27 14:19 ` Asmaa Mnebhi
2021-09-27 14:26 ` Asmaa Mnebhi
2021-09-27 14:56 ` Andrew Lunn
2021-09-27 15:52 ` Asmaa Mnebhi
2021-09-27 19:10 ` Andrew Lunn
2021-09-29 19:14 ` Asmaa Mnebhi
2021-09-28 15:02 ` Asmaa Mnebhi
2021-09-29 20:24 ` Andrew Lunn
2021-10-08 14:47 ` Asmaa Mnebhi
2021-09-23 20:22 ` [PATCH v3 2/2] net: mellanox: mlxbf_gige: Replace non-standard interrupt handling Asmaa Mnebhi
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 20:18 [PATCH v3 0/2] gpio: mlxbf2: Introduce proper " Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923202216.16091-1-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).