From: Tuan Phan <tuanphan@amperemail.onmicrosoft.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tuan Phan <tuanphan@os.amperecomputing.com>,
patches@amperecomputing.com, Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
Neil Leeder <nleeder@codeaurora.org>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ACPI/IORT: Fix PMCG node single ID mapping handling.
Date: Wed, 20 May 2020 10:07:20 -0700 [thread overview]
Message-ID: <2C9161BC-A333-4AF4-B277-D8BC64A3F1B9@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20200520125813.GA6906@e121166-lin.cambridge.arm.com>
> On May 20, 2020, at 5:58 AM, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
>
> On Fri, May 15, 2020 at 12:24:46PM -0700, Tuan Phan wrote:
>> An IORT PMCG node can have no ID mapping if its overflow interrupt is
>> wire based therefore the code that parses the PMCG node can not assume
>> the node will always have a single mapping present at index 0.
>>
>> Fix iort_get_id_mapping_index() by checking for an overflow interrupt
>> and mapping count.
>>
>> Fixes: 24e516049360 ("ACPI/IORT: Add support for PMCG").
>
> Remove these periods in the $SUBJECT and commit references, I
> don't know why you keep adding them.
>
> Anyway - I don't know if it is too late for v5.8 but this patch
> is ready to be merged (minus the nits I have just mentioned).
Thanks, will fix it.
>
> Lorenzo
>
>> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Reviewed-by: Hanjun Guo <guoahanjun@huawei.com>
>> Signed-off-by: Tuan Phan <tuanphan@os.amperecomputing.com>
>> ---
>> v1 -> v2:
>> - Use pmcg node to detect wired base overflow interrupt.
>>
>> v2 -> v3:
>> - Address Hanjun and Robin's comments.
>>
>> v3 -> v4:
>> - Update the title and description as mentioned by Lorenzo.
>>
>> drivers/acpi/arm64/iort.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index ed3d2d1..12bb70e 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -414,6 +414,7 @@ static struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
>> static int iort_get_id_mapping_index(struct acpi_iort_node *node)
>> {
>> struct acpi_iort_smmu_v3 *smmu;
>> + struct acpi_iort_pmcg *pmcg;
>>
>> switch (node->type) {
>> case ACPI_IORT_NODE_SMMU_V3:
>> @@ -441,6 +442,10 @@ static int iort_get_id_mapping_index(struct acpi_iort_node *node)
>>
>> return smmu->id_mapping_index;
>> case ACPI_IORT_NODE_PMCG:
>> + pmcg = (struct acpi_iort_pmcg *)node->node_data;
>> + if (pmcg->overflow_gsiv || node->mapping_count == 0)
>> + return -EINVAL;
>> +
>> return 0;
>> default:
>> return -EINVAL;
>> --
>> 2.7.4
>>
prev parent reply other threads:[~2020-05-20 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 19:24 [PATCH v4] ACPI/IORT: Fix PMCG node single ID mapping handling Tuan Phan
2020-05-20 12:58 ` Lorenzo Pieralisi
2020-05-20 17:07 ` Tuan Phan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2C9161BC-A333-4AF4-B277-D8BC64A3F1B9@amperemail.onmicrosoft.com \
--to=tuanphan@amperemail.onmicrosoft.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nleeder@codeaurora.org \
--cc=patches@amperecomputing.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sudeep.holla@arm.com \
--cc=tuanphan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).