From: "David E. Box" <david.e.box@linux.intel.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"lenb@kernel.org" <lenb@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property
Date: Fri, 01 May 2020 08:54:34 -0700 [thread overview]
Message-ID: <4ef802c221ba879d87bc202487f0ac5f6b01e9f1.camel@linux.intel.com> (raw)
In-Reply-To: <20200501131259.GB6600@lst.de>
On Fri, 2020-05-01 at 15:12 +0200, hch@lst.de wrote:
> On Wed, Apr 29, 2020 at 09:11:13AM -0700, David E. Box wrote:
> > Not drop completely. This patch copied the code used to read _DSD
> > properties under PCI root ports. But I agree that such properties
> > should apply to all devices on those ports and unfortuntely that's
> > not
> > the case here. BIOS got it wrong. My thought in dropping this patch
> > is
> > to rewrite it to read the property directly from the nvme driver.
> > Not
> > the way it's typically done either but it would avoid a global
> > change
> > in the pci core while allowing us to deal with the firmware we
> > have.
>
> I'd be happy to heave less of this crap in nvme actually. But I'm
> really
> pissed this shit got out in the wild. It wasn't clear from the mail
> that this is something already out there because the idiots coming up
> with it just went ahead with it. Please just update the commit logs
> and implementation to clearly mark it as a workaround for buggys
> systems, which just happen to at least be nice enough to tell us that
> they are buggy as f^$k.
Sure.
next prev parent reply other threads:[~2020-05-01 15:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 0:32 [PATCH 0/2] Add support for StorageD3Enable _DSD property David E. Box
2020-04-28 0:32 ` [PATCH 1/2] pci: Add ACPI StorageD3Enable _DSD support David E. Box
2020-05-18 12:34 ` Rafael J. Wysocki
2020-05-19 17:10 ` David E. Box
2020-04-28 0:32 ` [PATCH 2/2] drivers/nvme: Add support for ACPI StorageD3Enable property David E. Box
2020-04-28 5:13 ` [PATCH 0/2] Add support for StorageD3Enable _DSD property Christoph Hellwig
2020-04-28 14:09 ` David E. Box
2020-04-28 14:22 ` Christoph Hellwig
2020-04-28 15:27 ` David E. Box
2020-04-29 5:20 ` Williams, Dan J
2020-04-29 15:10 ` Keith Busch
2020-04-29 16:11 ` David E. Box
2020-05-01 13:12 ` hch
2020-05-01 15:54 ` David E. Box [this message]
2020-05-01 13:10 ` hch
2020-05-18 13:51 ` David Woodhouse
2020-05-18 17:20 ` Dan Williams
2020-06-12 20:48 ` [PATCH V2 0/2] nvme: Add support for ACPI StorageD3Enable property David E. Box
2020-06-24 18:55 ` David E. Box
2020-06-24 19:10 ` Dan Williams
2020-06-24 19:39 ` David E. Box
2020-07-02 21:04 ` [PATCH v3] drivers/nvme: " David E. Box
2020-07-02 22:50 ` [PATCH v4] " David E. Box
2020-07-03 7:18 ` kernel test robot
2020-07-06 14:57 ` Rafael J. Wysocki
2020-07-07 21:24 ` David E. Box
2020-07-07 7:09 ` Christoph Hellwig
2020-07-09 18:43 ` [PATCH V5] " David E. Box
2020-07-13 11:12 ` Rafael J. Wysocki
2020-07-16 14:39 ` Christoph Hellwig
2021-05-26 19:25 ` Raul E Rangel
2020-06-12 20:48 ` [PATCH V2 1/2] PCI: Add ACPI StorageD3Enable _DSD support David E. Box
2020-06-24 21:15 ` Bjorn Helgaas
2020-06-25 11:30 ` Rafael J. Wysocki
2020-06-25 12:16 ` Mika Westerberg
2020-06-25 17:07 ` David E. Box
2020-06-25 17:30 ` Bjorn Helgaas
2020-06-24 21:37 ` Bjorn Helgaas
2020-06-24 22:09 ` David E. Box
2020-06-12 20:48 ` [PATCH V2 2/2] drivers/nvme: Add support for ACPI StorageD3Enable property David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef802c221ba879d87bc202487f0ac5f6b01e9f1.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).