linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi <linux-acpi@vger.kernel.org>
Subject: [5.12 regression] DSDT overriding from initrd no longer works
Date: Mon, 12 Apr 2021 19:38:15 +0200	[thread overview]
Message-ID: <7d941a3c-bced-09cf-27a1-b61f0d20ef4c@redhat.com> (raw)

Hi Rafael,

Sorry about the timing of reporting this regression.

I just noticed that overriding the DSDT (*) from the initrd will not work in 5.12,
this is caused by:

commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables")

This makes the initial acpi_locate_initial_tables() call happen earlier
then before, but the acpi_table_upgrade) call in arch/x86/kernel/setup.c is
not moved up, so the tables in the initrd are now only parsed and saved
after the initial ACPI table scanning has already been done.

I guess fixing this might be as easy as moving the acpi_table_upgrade) call
higher in arch/x86/kernel/setup.c but I'm not sure if that is save to do.

I've several devices with ACPI tables which are so broken that they need
an override. I've reverted the commit from my personal tree for now which
avoids the regression.

Regards,

Hans


             reply	other threads:[~2021-04-12 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 17:38 Hans de Goede [this message]
2021-04-12 18:01 ` [5.12 regression] DSDT overriding from initrd no longer works Rafael J. Wysocki
2021-04-12 18:11   ` Rafael J. Wysocki
2021-04-12 18:53     ` Hans de Goede
2021-04-13  9:35       ` Rafael J. Wysocki
2021-04-13 10:52         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d941a3c-bced-09cf-27a1-b61f0d20ef4c@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).