From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Jon <jon@solid-run.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
netdev <netdev@vger.kernel.org>,
linux.cj@gmail.com,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [net-next PATCH v5 2/6] net: phy: introduce device_mdiobus_register()
Date: Fri, 10 Jul 2020 23:56:55 +0300 [thread overview]
Message-ID: <CAHp75VdAykaFSSVprwHnVaeE6EcU5dMoS7vDiaHVFDQox-YhcQ@mail.gmail.com> (raw)
In-Reply-To: <20200710163115.2740-3-calvin.johnson@oss.nxp.com>
On Fri, Jul 10, 2020 at 7:31 PM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> Introduce device_mdiobus_register() to register mdiobus
> in cases of either DT or ACPI.
...
> +/**
> + * device_mdiobus_register - bring up all the PHYs on a given bus and
> + * attach them to bus. This handles both DT and ACPI methods.
I guess you can shrink this to fit one line.
> + * @bus: target mii_bus
> + * @dev: given MDIO device
> + *
> + * Description: Given an MDIO device and target mii bus, this function
> + * calls of_mdiobus_register() for DT node and mdiobus_register() in
> + * case of ACPI.
> + *
> + * Returns 0 on success or negative error code on failure.
> + */
> +int device_mdiobus_register(struct mii_bus *bus,
> + struct device *dev)
It's a bit strange to have a function in device_* namespace to take a
pointer to the struct device as not the first parameter...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-10 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:31 [net-next PATCH v5 0/6] ACPI support for dpaa2 MAC driver Calvin Johnson
2020-07-10 16:31 ` [net-next PATCH v5 1/6] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-07-10 16:31 ` [net-next PATCH v5 2/6] net: phy: introduce device_mdiobus_register() Calvin Johnson
2020-07-10 20:56 ` Andy Shevchenko [this message]
2020-07-10 16:31 ` [net-next PATCH v5 3/6] net/fsl: use device_mdiobus_register() Calvin Johnson
2020-07-10 16:31 ` [net-next PATCH v5 4/6] net: phy: introduce phy_find_by_mdio_handle() Calvin Johnson
2020-07-10 16:31 ` [net-next PATCH v5 5/6] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-07-10 21:01 ` Andy Shevchenko
2020-07-10 16:31 ` [net-next PATCH v5 6/6] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdAykaFSSVprwHnVaeE6EcU5dMoS7vDiaHVFDQox-YhcQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).