From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control
Date: Fri, 15 May 2020 18:28:22 +0200 [thread overview]
Message-ID: <CAJZ5v0gRScLoBGr6546=zJBtZj2D0-Yv48RZobN-0eih01L29A@mail.gmail.com> (raw)
In-Reply-To: <4ea6a89bcde8c72427e69a87551bdfca8bf1af11.1589262490.git.mchehab+huawei@kernel.org>
On Tue, May 12, 2020 at 7:52 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> On Asus T101HA, we keep receiving those error messages:
>
> i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
> intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
> intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff
>
> Because the opregion is missing the I2C address.
>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> index 7ccd7d9660bc..a5101b07611a 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> @@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
> .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
> .thermal_table = chtdc_ti_thermal_table,
> .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
> + .pmic_i2c_address = 0x5e,
> };
>
> static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
> --
This appears to be part of a series, but the second patch has not been
CCed to linux-acpi.
Can I assume that this one will be applied along with the [2/2] by
another maintainer?
Thanks!
next prev parent reply other threads:[~2020-05-15 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 5:51 [PATCH 0/2] Solve a few issues with intel_pmic_chtdc_ti.c Mauro Carvalho Chehab
2020-05-12 5:51 ` [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control Mauro Carvalho Chehab
2020-05-12 7:45 ` Hans de Goede
2020-05-12 8:48 ` Mika Westerberg
2020-05-12 9:14 ` Andy Shevchenko
2020-05-15 16:28 ` Rafael J. Wysocki [this message]
2020-05-18 7:22 ` Hans de Goede
2020-05-18 8:18 ` Mauro Carvalho Chehab
2020-05-18 11:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gRScLoBGr6546=zJBtZj2D0-Yv48RZobN-0eih01L29A@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).