From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2] ACPI: scan: Use pr_debug replace ACPI_DEBUG_PRINT()
Date: Fri, 2 Oct 2020 19:11:42 +0200 [thread overview]
Message-ID: <CAJZ5v0hni_MqqoUB5ikPxMP5ZUmS38XGA8=r1LzVfAuT0HDSog@mail.gmail.com> (raw)
In-Reply-To: <1601169268-12062-1-git-send-email-tiantao6@hisilicon.com>
On Sun, Sep 27, 2020 at 3:17 AM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
> drivers/acpi/scan.c: In function ‘acpi_bus_get_wakeup_device_flags’:
> drivers/acpi/scan.c:902:43: warning: suggest braces around empty body in
> an ‘if’ statement [-Wempty-body]
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2:rewrite the patch and change the patch name.
> ---
> drivers/acpi/scan.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 2142f15..684c726 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -898,8 +898,7 @@ static void acpi_bus_get_wakeup_device_flags(struct acpi_device *device)
> */
> err = acpi_device_sleep_wake(device, 0, 0, 0);
> if (err)
> - ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> - "error in _DSW or _PSW evaluation\n"));
> + pr_debug("error in _DSW or _PSW evaluation\n");
> }
>
> static void acpi_bus_init_power_state(struct acpi_device *device, int state)
> --
Applied as 5.10 material with edited subject and changelog, thanks!
prev parent reply other threads:[~2020-10-02 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 1:14 [PATCH v2] ACPI: scan: Use pr_debug replace ACPI_DEBUG_PRINT() Tian Tao
2020-10-02 17:11 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0hni_MqqoUB5ikPxMP5ZUmS38XGA8=r1LzVfAuT0HDSog@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).