From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org,
will@kernel.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org,
virtualization@lists.linux-foundation.org, eric.auger@redhat.com,
sebastien.boeuf@intel.com, robin.murphy@arm.com,
kevin.tian@intel.com, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH 3/3] iommu/virtio: Enable x86 support
Date: Thu, 15 Apr 2021 17:15:18 +0200 [thread overview]
Message-ID: <YHhYhoDn3zQ9MaGB@myrica> (raw)
In-Reply-To: <20210318142709-mutt-send-email-mst@kernel.org>
On Thu, Mar 18, 2021 at 02:28:02PM -0400, Michael S. Tsirkin wrote:
> On Tue, Mar 16, 2021 at 08:16:54PM +0100, Jean-Philippe Brucker wrote:
> > With the VIOT support in place, x86 platforms can now use the
> > virtio-iommu.
> >
> > The arm64 Kconfig selects IOMMU_DMA, while x86 IOMMU drivers select it
> > themselves.
> >
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> > ---
> > drivers/iommu/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > index 2819b5c8ec30..ccca83ef2f06 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -400,8 +400,9 @@ config HYPERV_IOMMU
> > config VIRTIO_IOMMU
> > tristate "Virtio IOMMU driver"
> > depends on VIRTIO
> > - depends on ARM64
> > + depends on (ARM64 || X86)
> > select IOMMU_API
> > + select IOMMU_DMA if X86
>
> Would it hurt to just select unconditionally? Seems a bit cleaner
> ...
Yes I think I'll do this for the moment
Thanks,
Jean
>
> > select INTERVAL_TREE
> > select ACPI_VIOT if ACPI
> > help
> > --
> > 2.30.2
>
next prev parent reply other threads:[~2021-04-15 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 19:16 [PATCH 0/3] Add support for ACPI VIOT Jean-Philippe Brucker
2021-03-16 19:16 ` [PATCH 1/3] ACPICA: iASL: Add definitions for the VIOT table Jean-Philippe Brucker
2021-03-18 17:52 ` Auger Eric
2021-04-15 14:36 ` Jean-Philippe Brucker
2021-03-16 19:16 ` [PATCH 2/3] ACPI: Add driver " Jean-Philippe Brucker
2021-03-18 19:36 ` Robin Murphy
2021-04-15 14:31 ` Jean-Philippe Brucker
2021-03-19 10:44 ` Auger Eric
2021-04-15 14:46 ` Jean-Philippe Brucker
2021-03-16 19:16 ` [PATCH 3/3] iommu/virtio: Enable x86 support Jean-Philippe Brucker
2021-03-18 10:44 ` Joerg Roedel
2021-03-18 11:43 ` Robin Murphy
2021-04-15 15:14 ` Jean-Philippe Brucker
2021-03-18 18:28 ` Michael S. Tsirkin
2021-04-15 15:15 ` Jean-Philippe Brucker [this message]
2021-03-19 10:58 ` [PATCH 0/3] Add support for ACPI VIOT Auger Eric
2021-03-19 11:16 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHhYhoDn3zQ9MaGB@myrica \
--to=jean-philippe@linaro.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mst@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=sebastien.boeuf@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).