From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Vladimir Oltean <olteanv@gmail.com>,
"Cc: Android Kernel" <kernel-team@android.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD
Date: Sun, 19 Sep 2021 08:41:30 +0200 [thread overview]
Message-ID: <YUbbmuOJkauJUU8m@kroah.com> (raw)
In-Reply-To: <YUaPcgc03r/Dw0yk@lunn.ch>
On Sun, Sep 19, 2021 at 03:16:34AM +0200, Andrew Lunn wrote:
> > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> > > index 59828516ebaf..9f4ad719bfe3 100644
> > > --- a/include/linux/fwnode.h
> > > +++ b/include/linux/fwnode.h
> > > @@ -22,10 +22,15 @@ struct device;
> > > * LINKS_ADDED: The fwnode has already be parsed to add fwnode links.
> > > * NOT_DEVICE: The fwnode will never be populated as a struct device.
> > > * INITIALIZED: The hardware corresponding to fwnode has been initialized.
> > > + * NEEDS_CHILD_BOUND_ON_ADD: For this fwnode/device to probe successfully, its
> > > + * driver needs its child devices to be bound with
> > > + * their respective drivers as soon as they are
> > > + * added.
> >
> > The fact that this requires so much comment text here is a clear
> > band-aid indication to me.
>
> This whole patchset is a band aid, but it is for stable, to fix things
> which are currently broken. So we need to answer the question, is a
> bad aid good enough for stable, with the assumption a real fix will
> come along later?
Fix it properly first and worry about stable later.
greg k-h
next prev parent reply other threads:[~2021-09-19 6:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 17:09 [PATCH v3 0/3] fw_devlink bug fixes Saravana Kannan
2021-09-15 17:09 ` [PATCH v3 1/3] driver core: fw_devlink: Improve handling of cyclic dependencies Saravana Kannan
2021-09-18 14:38 ` Rafael J. Wysocki
2021-09-15 17:09 ` [PATCH v3 2/3] driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD Saravana Kannan
2021-09-18 15:03 ` Rafael J. Wysocki
2021-09-19 1:16 ` Andrew Lunn
2021-09-19 6:41 ` Greg Kroah-Hartman [this message]
2021-09-21 16:15 ` Greg Kroah-Hartman
2021-09-21 16:35 ` Rafael J. Wysocki
2021-09-21 17:56 ` Andrew Lunn
2021-09-21 18:56 ` Rafael J. Wysocki
2021-09-21 19:50 ` Andrew Lunn
2021-09-21 20:07 ` Saravana Kannan
2021-09-21 21:02 ` Andrew Lunn
2021-09-21 21:54 ` Saravana Kannan
2021-09-21 22:04 ` Andrew Lunn
2021-09-21 22:26 ` Saravana Kannan
2021-09-22 0:45 ` Andrew Lunn
2021-09-22 1:00 ` Saravana Kannan
2021-09-22 12:52 ` Andrew Lunn
2021-09-23 12:48 ` Rafael J. Wysocki
2021-09-15 17:09 ` [PATCH v3 3/3] net: mdiobus: Set FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD for mdiobus parents Saravana Kannan
2021-09-23 17:30 ` [PATCH v3 0/3] fw_devlink bug fixes Greg Kroah-Hartman
2021-09-23 19:44 ` Vladimir Oltean
2021-09-24 6:09 ` Greg Kroah-Hartman
2021-09-23 22:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUbbmuOJkauJUU8m@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).