From: Jianxin Pan <jianxin.pan@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Hanjie Lin <hanjie.lin@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
linux-pm@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, Jian Hu <jian.hu@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: power: add Amlogic secure power domains bindings
Date: Tue, 29 Oct 2019 20:09:39 +0800 [thread overview]
Message-ID: <07f0ed9d-0b1a-d84f-de8b-1967e56bbd21@amlogic.com> (raw)
In-Reply-To: <20191029020125.GA11182@bogus>
Hi Jerome,
Could you give some advice about this?
In a1/c1, watchdog and powerdomain are the same, they use secure monitor [0] and
there is no share memory needed.
[0]
https://lore.kernel.org/linux-amlogic/20190731082339.20163-1-ccaione@baylibre.com/
On 2019/10/29 10:01, Rob Herring wrote:
> On Fri, Oct 18, 2019 at 05:32:44PM +0800, Jianxin Pan wrote:
>> Add the bindings for the Amlogic Secure power domains, controlling the
>> secure power domains.
>>
>> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the
>> power domain registers are in secure world.
>>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> ---
>> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 42 ++++++++++++++++++++++
>> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++
>> 2 files changed, 74 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> create mode 100644 include/dt-bindings/power/meson-a1-power.h
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> new file mode 100644
>> index 00000000..88d8261
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +# Copyright (c) 2019 Amlogic, Inc
>> +# Author: Jianxin Pan <jianxin.pan@amlogic.com>
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-pwrc.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic Meson Secure Power Domains
>> +
>> +maintainers:
>> + - Jianxin Pan <jianxin.pan@amlogic.com>
>> +
>> +description: |+
>> + Meson Secure Power Domains used in A1/C1 SoCs.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,meson-a1-pwrc
>> +
>> + "#power-domain-cells":
>> + const: 1
>> +
>> + secure-monitor:
>> + description: phandle to the secure-monitor node
>> + $ref: /schemas/types.yaml#/definitions/phandle
>
> Like the watchdog, make this a child or the secure firmware node. Or
> just add '#power-domain-cells' to it. You don't really need a child node
> here if there's not other resources in DT for this.
>
> Rob
>
> .
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-10-29 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:32 [PATCH RESEND v3 0/4] arm64: meson: add support for A1 Power Domains Jianxin Pan
2019-10-18 9:32 ` [PATCH v3 1/4] dt-bindings: power: add Amlogic secure power domains bindings Jianxin Pan
2019-10-29 2:01 ` Rob Herring
2019-10-29 12:09 ` Jianxin Pan [this message]
2019-10-18 9:32 ` [PATCH v3 2/4] firmware: meson_sm: Add secure power domain support Jianxin Pan
2019-10-18 9:32 ` [PATCH v3 3/4] soc: amlogic: Add support for Secure power domains controller Jianxin Pan
2019-10-18 9:32 ` [PATCH v3 4/4] arm64: dts: meson: a1: add secure power domain controller Jianxin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f0ed9d-0b1a-d84f-de8b-1967e56bbd21@amlogic.com \
--to=jianxin.pan@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).