From: Stephen Boyd <sboyd@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical
Date: Tue, 23 Apr 2019 11:25:07 -0700 [thread overview]
Message-ID: <155604390724.15276.2042141881910266821@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190423091503.10847-4-narmstrong@baylibre.com>
Quoting Neil Armstrong (2019-04-23 02:15:00)
> On Amlogic Meson G12b platform, the fclk_div3 seems to be necessary for
> the system to operate correctly.
>
> Disabling it cause the entire system to freeze, including peripherals.
>
> This patch patch marks this clock as critical, fixing boot on G12b platforms.
s/patch//
Usually we don't say "This patch" because the voice should be
imperative. From submitting-patches.rst:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-23 18:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:14 [PATCH v2 0/6] arm64: Add initial support for Odroid-N2 Neil Armstrong
2019-04-23 9:14 ` [PATCH v2 1/6] dt-bindings: clk: meson: add g12b periph clock controller bindings Neil Armstrong
2019-04-27 20:18 ` Martin Blumenstingl
2019-04-23 9:14 ` [PATCH v2 2/6] clk: meson: g12a: Add support for G12B CPUB clocks Neil Armstrong
2019-04-27 20:20 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical Neil Armstrong
2019-04-23 18:25 ` Stephen Boyd [this message]
2019-04-23 9:15 ` [PATCH v2 4/6] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-04-27 20:22 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 5/6] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-04-27 20:23 ` Martin Blumenstingl
2019-04-23 9:15 ` [PATCH v2 6/6] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-04-27 20:26 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155604390724.15276.2042141881910266821@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).